From b340c733fc5bfc6b6ce52b332c9ae5b536fd5fbc Mon Sep 17 00:00:00 2001 From: Xie XiuQi Date: Mon, 15 Apr 2019 18:07:47 +0800 Subject: [PATCH] sched: fix unsigned check error hulk inclusion category: bugfix bugzilla: 4586 CVE: NA period is unsigned int, so this check is error, so this check is useless. Fix it. Reviewed-by: Yang Yingliang Signed-off-by: Yang Yingliang --- kernel/sched/fair.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c index 1ed7c1a45480..c52232d2abb8 100644 --- a/kernel/sched/fair.c +++ b/kernel/sched/fair.c @@ -2018,7 +2018,7 @@ static u64 numa_get_avg_runtime(struct task_struct *p, u64 *period) *period = now - p->last_task_numa_placement; /* Avoid backward, and prevent potential divide error */ - if (*period < 0) + if ((s64)*period < 0) *period = 0; } else { delta = p->se.avg.load_sum; -- GitLab