You need to sign in or sign up before continuing.
提交 9c012cf2 编写于 作者: S Stephane Eranian 提交者: Xie XiuQi

perf/core: Restore mmap record type correctly

mainline inclusion
from mainline-5.1-rc2
commit d9c1bb2f6a21
category: bugfix
bugzilla: 13165
CVE: NA

-------------------------------------------------

On mmap(), perf_events generates a RECORD_MMAP record and then checks
which events are interested in this record. There are currently 2
versions of mmap records: RECORD_MMAP and RECORD_MMAP2. MMAP2 is larger.
The event configuration controls which version the user level tool
accepts.

If the event->attr.mmap2=1 field then MMAP2 record is returned.  The
perf_event_mmap_output() takes care of this. It checks attr->mmap2 and
corrects the record fields before putting it in the sampling buffer of
the event.  At the end the function restores the modified MMAP record
fields.

The problem is that the function restores the size but not the type.
Thus, if a subsequent event only accepts MMAP type, then it would
instead receive an MMAP2 record with a size of MMAP record.

This patch fixes the problem by restoring the record type on exit.
Signed-off-by: NStephane Eranian <eranian@google.com>
Acked-by: NPeter Zijlstra (Intel) <peterz@infradead.org>
Cc: Andi Kleen <ak@linux.intel.com>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Kan Liang <kan.liang@linux.intel.com>
Fixes: 13d7a241 ("perf: Add attr->mmap2 attribute to an event")
Link: http://lkml.kernel.org/r/20190307185233.225521-1-eranian@google.comSigned-off-by: NArnaldo Carvalho de Melo <acme@redhat.com>
Signed-off-by: NWei Li <liwei391@huawei.com>
Reviewed-by: NCheng Jian <cj.chengjian@huawei.com>
Signed-off-by: NYang Yingliang <yangyingliang@huawei.com>
上级 293c3d5e
...@@ -7202,6 +7202,7 @@ static void perf_event_mmap_output(struct perf_event *event, ...@@ -7202,6 +7202,7 @@ static void perf_event_mmap_output(struct perf_event *event,
struct perf_output_handle handle; struct perf_output_handle handle;
struct perf_sample_data sample; struct perf_sample_data sample;
int size = mmap_event->event_id.header.size; int size = mmap_event->event_id.header.size;
u32 type = mmap_event->event_id.header.type;
int ret; int ret;
if (!perf_event_mmap_match(event, data)) if (!perf_event_mmap_match(event, data))
...@@ -7245,6 +7246,7 @@ static void perf_event_mmap_output(struct perf_event *event, ...@@ -7245,6 +7246,7 @@ static void perf_event_mmap_output(struct perf_event *event,
perf_output_end(&handle); perf_output_end(&handle);
out: out:
mmap_event->event_id.header.size = size; mmap_event->event_id.header.size = size;
mmap_event->event_id.header.type = type;
} }
static void perf_event_mmap_event(struct perf_mmap_event *mmap_event) static void perf_event_mmap_event(struct perf_mmap_event *mmap_event)
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册