From 91264b1b1cbab37297e38df59de924ff5729cf3e Mon Sep 17 00:00:00 2001 From: zhengbin Date: Tue, 19 Mar 2019 14:23:45 +0000 Subject: [PATCH] 9p/net: fix memory leak in p9_client_create mainline inclusion from mainline-5.1-rc1 commit bb06c388fa20 category: bugfix bugzilla: 12795 CVE: NA ------------------------------------------------- If msize is less than 4096, we should close and put trans, destroy tagpool, not just free client. This patch fixes that. Link: http://lkml.kernel.org/m/1552464097-142659-1-git-send-email-zhengbin13@huawei.com Cc: stable@vger.kernel.org Fixes: 574d356b7a02 ("9p/net: put a lower bound on msize") Reported-by: Hulk Robot Signed-off-by: zhengbin Signed-off-by: Dominique Martinet Signed-off-by: Zhiqiang Liu Reviewed-by: Wenan Mao Signed-off-by: Yang Yingliang --- net/9p/client.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/9p/client.c b/net/9p/client.c index 75b7bf7c7f07..23ec6187dc07 100644 --- a/net/9p/client.c +++ b/net/9p/client.c @@ -1073,7 +1073,7 @@ struct p9_client *p9_client_create(const char *dev_name, char *options) p9_debug(P9_DEBUG_ERROR, "Please specify a msize of at least 4k\n"); err = -EINVAL; - goto free_client; + goto close_trans; } err = p9_client_version(clnt); -- GitLab