From 8893f519330bb073a49c5b4676fce4be6f1be15d Mon Sep 17 00:00:00 2001 From: Paul Gortmaker Date: Fri, 24 Feb 2017 15:01:09 -0800 Subject: [PATCH] lib/test_sort.c: make it explicitly non-modular The Kconfig currently controlling compilation of this code is: lib/Kconfig.debug:config TEST_SORT lib/Kconfig.debug: bool "Array-based sort test" ...meaning that it currently is not being built as a module by anyone. Lets remove the couple traces of modular infrastructure use, so that when reading the code there is no doubt it is builtin-only. Since module_init translates to device_initcall in the non-modular case, the init ordering becomes slightly earlier when we change it to use subsys_initcall as done here. However, since it is a self contained test, this shouldn't be an issue and subsys_initcall seems like a better fit for this particular case. We also delete the MODULE_LICENSE tag since that information is now contained at the top of the file in the comments. Link: http://lkml.kernel.org/r/20170124225608.7319-1-paul.gortmaker@windriver.com Signed-off-by: Paul Gortmaker Cc: Kostenzer Felix Cc: Arnd Bergmann Signed-off-by: Andrew Morton Signed-off-by: Linus Torvalds --- lib/test_sort.c | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/lib/test_sort.c b/lib/test_sort.c index d389c1cc2f6c..4db3911db50a 100644 --- a/lib/test_sort.c +++ b/lib/test_sort.c @@ -1,8 +1,11 @@ #include #include -#include +#include -/* a simple boot-time regression test */ +/* + * A simple boot-time regression test + * License: GPL + */ #define TEST_LEN 1000 @@ -38,6 +41,4 @@ static int __init test_sort_init(void) kfree(a); return err; } - -module_init(test_sort_init); -MODULE_LICENSE("GPL"); +subsys_initcall(test_sort_init); -- GitLab