From 827fe0df86f89931a0df4c6c11982f53ac0022e7 Mon Sep 17 00:00:00 2001 From: shenjian Date: Tue, 23 Apr 2019 18:36:21 +0800 Subject: [PATCH] net: hns3: remove redundant fixup callback driver inclusion category: bugfix bugzilla: NA CVE: NA It's unnecessary to register a fixup callback to set dev_flags before connecting phy, and unregister it when disconnecting it. We just set dev_flags directly before connecting phy. Signed-off-by: shenjian (K) Reviewed-by: lipeng Reviewed-by: Hanjun Guo Signed-off-by: Yang Yingliang --- drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_mdio.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_mdio.c b/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_mdio.c index 2beaf8d69dee..499779f53d90 100644 --- a/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_mdio.c +++ b/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_mdio.c @@ -193,6 +193,10 @@ int hclge_mac_connect_phy(struct hnae3_handle *handle) if (!phydev) return 0; +#ifdef MARVELL_PHY_M1510_HNS3_LEDS + phydev->dev_flags |= MARVELL_PHY_M1510_HNS3_LEDS; +#endif + #ifdef HAS_LINK_MODE_OPS linkmode_clear_bit(ETHTOOL_LINK_MODE_FIBRE_BIT, phydev->supported); -- GitLab