提交 6715ca45 编写于 作者: O Oleg Nesterov 提交者: Linus Torvalds

signals: collect_signal: remove the unneeded sigismember() check

collect_signal() checks sigismember(&list->signal, sig), this is not
needed.  This "sig" was just found by next_signal(), so it must be valid.

We have a (completely broken) call to ->notifier in between, but it must
not play with sigpending->signal bits or unlock ->siglock.
Signed-off-by: NOleg Nesterov <oleg@tv-sign.ru>
Acked-by: NRoland McGrath <roland@redhat.com>
Signed-off-by: NAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: NLinus Torvalds <torvalds@linux-foundation.org>
上级 96347e77
...@@ -343,9 +343,6 @@ static int collect_signal(int sig, struct sigpending *list, siginfo_t *info) ...@@ -343,9 +343,6 @@ static int collect_signal(int sig, struct sigpending *list, siginfo_t *info)
struct sigqueue *q, *first = NULL; struct sigqueue *q, *first = NULL;
int still_pending = 0; int still_pending = 0;
if (unlikely(!sigismember(&list->signal, sig)))
return 0;
/* /*
* Collect the siginfo appropriate to this signal. Check if * Collect the siginfo appropriate to this signal. Check if
* there is another siginfo for the same signal. * there is another siginfo for the same signal.
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册