From 5fabfbeaa344664a02ac8d02193b9d7c6857672d Mon Sep 17 00:00:00 2001 From: Vasily Averin Date: Thu, 28 Mar 2019 16:09:35 +0800 Subject: [PATCH] sunrpc: fix debug message in svc_create_xprt() mainline inclusion from mainline-5.0-rc1 commit 9ac312888e8869481613a2c65bb8bf5ab6d15594 category: bugfix bugzilla: 10613 CVE: NA --------------------------- _svc_create_xprt() returns positive port number so its non-zero return value is not an error Reviewed-by: Jeff Layton Signed-off-by: Vasily Averin Signed-off-by: J. Bruce Fields Signed-off-by: zhengbin Reviewed-by: yangerkun Signed-off-by: Yang Yingliang --- net/sunrpc/svc_xprt.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/net/sunrpc/svc_xprt.c b/net/sunrpc/svc_xprt.c index 6cf0fd37cbf0..cde15c373486 100644 --- a/net/sunrpc/svc_xprt.c +++ b/net/sunrpc/svc_xprt.c @@ -297,9 +297,9 @@ int svc_create_xprt(struct svc_serv *serv, const char *xprt_name, request_module("svc%s", xprt_name); err = _svc_create_xprt(serv, xprt_name, net, family, port, flags); } - if (err) + if (err < 0) dprintk("svc: transport %s not found, err %d\n", - xprt_name, err); + xprt_name, -err); return err; } EXPORT_SYMBOL_GPL(svc_create_xprt); -- GitLab