提交 55205053 编写于 作者: H H Hartley Sweeten 提交者: Greg Kroah-Hartman

staging: comedi: ni_tio: tidy up ni_660x_set_second_gate()

Rename some of the local vars and tidy up this function to fix to
fix a couple > 80 char line issues.
Signed-off-by: NH Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: NIan Abbott <abbotti@mev.co.uk>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
上级 85603161
...@@ -1052,43 +1052,34 @@ static int ni_660x_set_second_gate(struct ni_gpct *counter, ...@@ -1052,43 +1052,34 @@ static int ni_660x_set_second_gate(struct ni_gpct *counter,
{ {
struct ni_gpct_device *counter_dev = counter->counter_dev; struct ni_gpct_device *counter_dev = counter->counter_dev;
unsigned cidx = counter->counter_index; unsigned cidx = counter->counter_index;
const unsigned second_gate_reg = NITIO_GATE2_REG(cidx); unsigned int chan = CR_CHAN(gate_source);
const unsigned selected_second_gate = CR_CHAN(gate_source); unsigned gate2_reg = NITIO_GATE2_REG(cidx);
/* bits of second_gate that may be meaningful to second gate register */ unsigned gate2_sel;
static const unsigned selected_second_gate_mask = 0x1f;
unsigned ni_660x_second_gate_select;
unsigned i; unsigned i;
switch (selected_second_gate) { switch (chan) {
case NI_GPCT_SOURCE_PIN_i_GATE_SELECT: case NI_GPCT_SOURCE_PIN_i_GATE_SELECT:
case NI_GPCT_UP_DOWN_PIN_i_GATE_SELECT: case NI_GPCT_UP_DOWN_PIN_i_GATE_SELECT:
case NI_GPCT_SELECTED_GATE_GATE_SELECT: case NI_GPCT_SELECTED_GATE_GATE_SELECT:
case NI_GPCT_NEXT_OUT_GATE_SELECT: case NI_GPCT_NEXT_OUT_GATE_SELECT:
case NI_GPCT_LOGIC_LOW_GATE_SELECT: case NI_GPCT_LOGIC_LOW_GATE_SELECT:
ni_660x_second_gate_select = gate2_sel = chan & 0x1f;
selected_second_gate & selected_second_gate_mask;
break; break;
case NI_GPCT_NEXT_SOURCE_GATE_SELECT: case NI_GPCT_NEXT_SOURCE_GATE_SELECT:
ni_660x_second_gate_select = gate2_sel = NI_660x_Next_SRC_Second_Gate_Select;
NI_660x_Next_SRC_Second_Gate_Select;
break; break;
default: default:
for (i = 0; i <= ni_660x_max_rtsi_channel; ++i) { for (i = 0; i <= ni_660x_max_rtsi_channel; ++i) {
if (selected_second_gate == NI_GPCT_RTSI_GATE_SELECT(i)) { if (chan == NI_GPCT_RTSI_GATE_SELECT(i)) {
ni_660x_second_gate_select = gate2_sel = chan & 0x1f;
selected_second_gate &
selected_second_gate_mask;
break; break;
} }
} }
if (i <= ni_660x_max_rtsi_channel) if (i <= ni_660x_max_rtsi_channel)
break; break;
for (i = 0; i <= ni_660x_max_up_down_pin; ++i) { for (i = 0; i <= ni_660x_max_up_down_pin; ++i) {
if (selected_second_gate == if (chan == NI_GPCT_UP_DOWN_PIN_GATE_SELECT(i)) {
NI_GPCT_UP_DOWN_PIN_GATE_SELECT(i)) { gate2_sel = chan & 0x1f;
ni_660x_second_gate_select =
selected_second_gate &
selected_second_gate_mask;
break; break;
} }
} }
...@@ -1096,12 +1087,10 @@ static int ni_660x_set_second_gate(struct ni_gpct *counter, ...@@ -1096,12 +1087,10 @@ static int ni_660x_set_second_gate(struct ni_gpct *counter,
break; break;
return -EINVAL; return -EINVAL;
} }
counter_dev->regs[second_gate_reg] |= Gi_Second_Gate_Mode_Bit; counter_dev->regs[gate2_reg] |= Gi_Second_Gate_Mode_Bit;
counter_dev->regs[second_gate_reg] &= ~Gi_Second_Gate_Select_Mask; counter_dev->regs[gate2_reg] &= ~Gi_Second_Gate_Select_Mask;
counter_dev->regs[second_gate_reg] |= counter_dev->regs[gate2_reg] |= Gi_Second_Gate_Select_Bits(gate2_sel);
Gi_Second_Gate_Select_Bits(ni_660x_second_gate_select); write_register(counter, counter_dev->regs[gate2_reg], gate2_reg);
write_register(counter, counter_dev->regs[second_gate_reg],
second_gate_reg);
return 0; return 0;
} }
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册