提交 506026c3 编写于 作者: J Jeff Layton 提交者: Trond Myklebust

sunrpc: clarify comments on rpc_make_runnable

rpc_make_runnable is not generally called with the queue lock held, unless
it's waking up a task that has been sitting on a waitqueue. This is safe
when the task has not entered the FSM yet, but the comments don't really
spell this out.
Signed-off-by: NJeff Layton <jlayton@redhat.com>
Signed-off-by: NTrond Myklebust <Trond.Myklebust@netapp.com>
上级 159e0561
...@@ -300,8 +300,9 @@ EXPORT_SYMBOL_GPL(__rpc_wait_for_completion_task); ...@@ -300,8 +300,9 @@ EXPORT_SYMBOL_GPL(__rpc_wait_for_completion_task);
/* /*
* Make an RPC task runnable. * Make an RPC task runnable.
* *
* Note: If the task is ASYNC, this must be called with * Note: If the task is ASYNC, and is being made runnable after sitting on an
* the spinlock held to protect the wait queue operation. * rpc_wait_queue, this must be called with the queue spinlock held to protect
* the wait queue operation.
*/ */
static void rpc_make_runnable(struct rpc_task *task) static void rpc_make_runnable(struct rpc_task *task)
{ {
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册