From 4cd46bca8ca8ad20cadf74fd9b76364c46ed0f31 Mon Sep 17 00:00:00 2001
From: Tuukka Tikkanen <tuukka.tikkanen@linaro.org>
Date: Wed, 14 Aug 2013 19:02:37 +0300
Subject: [PATCH] cpuidle: CodingStyle: Break up multiple assignments on single
line
The function get_typical_interval() initializes a number of variables
that are immediately after declarations assigned constant values.
In addition, there are multiple assignments on a single line, which
is explicitly forbidden by Documentation/CodingStyle.
This patch removes redundant initial values for the variables and
breaks up the multiple assignment line.
Signed-off-by: Tuukka Tikkanen <tuukka.tikkanen@linaro.org>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
---
drivers/cpuidle/governors/menu.c | 9 ++++++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/drivers/cpuidle/governors/menu.c b/drivers/cpuidle/governors/menu.c
index af7b3f6b260d..94a303739ba8 100644
--- a/drivers/cpuidle/governors/menu.c
+++ b/drivers/cpuidle/governors/menu.c
@@ -199,14 +199,17 @@ static u64 div_round64(u64 dividend, u32 divisor)
*/
static void get_typical_interval(struct menu_device *data)
{
- int i = 0, divisor = 0;
- uint64_t max = 0, avg = 0, stddev = 0;
+ int i, divisor;
+ uint64_t max, avg, stddev;
int64_t thresh = LLONG_MAX; /* Discard outliers above this value. */
again:
/* first calculate average and standard deviation of the past */
- max = avg = divisor = stddev = 0;
+ max = 0;
+ avg = 0;
+ divisor = 0;
+ stddev = 0;
for (i = 0; i < INTERVALS; i++) {
int64_t value = data->intervals[i];
if (value <= thresh) {
--
GitLab