提交 4c11e554 编写于 作者: A Aaro Koskinen 提交者: Linus Torvalds

drivers/firmware/broadcom/bcm47xx_nvram.c: fix incorrect __ioread32_copy

Commit 1f330c32 ("drivers/firmware/broadcom/bcm47xx_nvram.c: use
__ioread32_copy() instead of open-coding") switched to use a generic
copy function, but failed to notice that the header pointer is updated
between the two copies, resulting in bogus data being copied in the
latter one.  Fix by keeping the old header pointer.

The patch fixes totally broken networking on WRT54GL router (both LAN and
WLAN interfaces fail to probe).

Fixes: 1f330c32 ("drivers/firmware/broadcom/bcm47xx_nvram.c: use __ioread32_copy() instead of open-coding")
Signed-off-by: NAaro Koskinen <aaro.koskinen@iki.fi>
Reviewed-by: NStephen Boyd <sboyd@codeaurora.org>
Cc: Rafal Milecki <zajec5@gmail.com>
Cc: Hauke Mehrtens <hauke@hauke-m.de>
Cc: <stable@vger.kernel.org>	[4.4.x]
Signed-off-by: NAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: NLinus Torvalds <torvalds@linux-foundation.org>
上级 b0f84ac3
...@@ -94,15 +94,14 @@ static int nvram_find_and_copy(void __iomem *iobase, u32 lim) ...@@ -94,15 +94,14 @@ static int nvram_find_and_copy(void __iomem *iobase, u32 lim)
found: found:
__ioread32_copy(nvram_buf, header, sizeof(*header) / 4); __ioread32_copy(nvram_buf, header, sizeof(*header) / 4);
header = (struct nvram_header *)nvram_buf; nvram_len = ((struct nvram_header *)(nvram_buf))->len;
nvram_len = header->len;
if (nvram_len > size) { if (nvram_len > size) {
pr_err("The nvram size according to the header seems to be bigger than the partition on flash\n"); pr_err("The nvram size according to the header seems to be bigger than the partition on flash\n");
nvram_len = size; nvram_len = size;
} }
if (nvram_len >= NVRAM_SPACE) { if (nvram_len >= NVRAM_SPACE) {
pr_err("nvram on flash (%i bytes) is bigger than the reserved space in memory, will just copy the first %i bytes\n", pr_err("nvram on flash (%i bytes) is bigger than the reserved space in memory, will just copy the first %i bytes\n",
header->len, NVRAM_SPACE - 1); nvram_len, NVRAM_SPACE - 1);
nvram_len = NVRAM_SPACE - 1; nvram_len = NVRAM_SPACE - 1;
} }
/* proceed reading data after header */ /* proceed reading data after header */
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册