From 49da02d3065382d637de039897745f89123eda4e Mon Sep 17 00:00:00 2001 From: Yonglong Liu Date: Thu, 23 May 2019 15:17:08 +0800 Subject: [PATCH] net: hns3: free irq when exit from abnormal branch driver inclusion category: bugfix bugzilla: NA CVE: NA In hns3_nic_init_irq(), if request irq fail at index i, the function return directly without releasing irq resources that already requested, and nowhere else will release them. Feature or Bugfix:Bugfix Signed-off-by: Yonglong Liu Reviewed-by: lipeng Reviewed-by: Yang Yingliang Signed-off-by: Yang Yingliang --- drivers/net/ethernet/hisilicon/hns3/hns3_enet.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c b/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c index 2286d0f062aa..1d20bb170be1 100644 --- a/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c +++ b/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c @@ -143,6 +143,7 @@ static int hns3_nic_init_irq(struct hns3_nic_priv *priv) if (ret) { netdev_err(priv->netdev, "request irq(%d) fail\n", tqp_vectors->vector_irq); + hns3_nic_uninit_irq(priv); return ret; } -- GitLab