From 433c08ac98254cd431b0bbf348924bd650ee4211 Mon Sep 17 00:00:00 2001 From: Yufeng Mo Date: Tue, 8 Oct 2019 16:45:32 +0800 Subject: [PATCH] net: hns3: modify the err log when setting invalid vf id driver inclusion category: bugfix bugzilla: NA CVE: NA This patch optimizes error log when entering invalid vfid to make it more reasonable. Fixes: 61bc2779e10b ("net: hns3: change the range of vf id set by ip link set") Feature or Bugfix:Bugfix Signed-off-by: Yufeng Mo Reviewed-by: lipeng Reviewed-by: Yunsheng Lin Signed-off-by: Yang Yingliang --- .../net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c b/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c index 87ed504c2603..293ba008bcef 100644 --- a/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c +++ b/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c @@ -2885,10 +2885,16 @@ static int hclge_get_status(struct hnae3_handle *handle) static struct hclge_vport *hclge_get_vf_vport(struct hclge_dev *hdev, int vf) { + if (pci_num_vf(hdev->pdev) == 0) { + dev_err(&hdev->pdev->dev, + "SRIOV is disabled, can not get vport(%d) info.\n", vf); + return NULL; + } + if (vf < 0 || vf >= pci_num_vf(hdev->pdev)) { dev_err(&hdev->pdev->dev, - "Out-of-range(1 < vfid < %d) or Invalid VF(=%d) specified.\n", - pci_num_vf(hdev->pdev), vf); + "vf id(%d) is out of range(0 <= vfid < %d)\n", + vf, pci_num_vf(hdev->pdev)); return NULL; } -- GitLab