From 3aebdd2d14790590a30c4268564cc93a99f19800 Mon Sep 17 00:00:00 2001 From: Lang Cheng Date: Mon, 20 May 2019 20:52:14 +0800 Subject: [PATCH] add return success to rereg_mr_trans driver inclusion category: bugfix bugzilla: NA CVE: NA When optimize hns_roce_rereg_user_mr, rereg_mr_trans does nt return immediately, but enters the exception handling branch. Although the return value is still 0, an umem release is performed. The correct return processing should be added. Fixes: d5c96b0495e7 ("RDMA/hns: RDMA/hns: Optimize hns_roce_rereg_user_mr function") Feature or Bugfix:Bugfix Signed-off-by: Lang Cheng Reviewed-by: liuyixian Reviewed-by: Yang Yingliang Signed-off-by: Yang Yingliang --- drivers/infiniband/hw/hns/hns_roce_mr.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/infiniband/hw/hns/hns_roce_mr.c b/drivers/infiniband/hw/hns/hns_roce_mr.c index d2747a00ee62..b420c480f0f4 100644 --- a/drivers/infiniband/hw/hns/hns_roce_mr.c +++ b/drivers/infiniband/hw/hns/hns_roce_mr.c @@ -1313,6 +1313,8 @@ static int rereg_mr_trans(struct ib_mr *ibmr, int flags, goto release_umem; } + return 0; + release_umem: ib_umem_release(mr->umem); return ret; -- GitLab