提交 37929729 编写于 作者: G Gen Zhang 提交者: Xie XiuQi

ip_sockglue: Fix missing-check bug in ip_ra_control()

mainline inclusion
from mainline-5.2-rc4
commit 425aa0e1
category: bugfix
bugzilla: 13690
CVE: CVE-2019-12381

-------------------------------------------------

In function ip_ra_control(), the pointer new_ra is allocated a memory
space via kmalloc(). And it is used in the following codes. However,
when  there is a memory allocation error, kmalloc() fails. Thus null
pointer dereference may happen. And it will cause the kernel to crash.
Therefore, we should check the return value and handle the error.
Signed-off-by: NGen Zhang <blackgod016574@gmail.com>
Signed-off-by: NDavid S. Miller <davem@davemloft.net>
Signed-off-by: NYang Yingliang <yangyingliang@huawei.com>
Reviewed-by: NYue Haibing <yuehaibing@huawei.com>
Signed-off-by: NYang Yingliang <yangyingliang@huawei.com>
上级 bc542c4c
...@@ -343,6 +343,8 @@ int ip_ra_control(struct sock *sk, unsigned char on, ...@@ -343,6 +343,8 @@ int ip_ra_control(struct sock *sk, unsigned char on,
return -EINVAL; return -EINVAL;
new_ra = on ? kmalloc(sizeof(*new_ra), GFP_KERNEL) : NULL; new_ra = on ? kmalloc(sizeof(*new_ra), GFP_KERNEL) : NULL;
if (on && !new_ra)
return -ENOMEM;
mutex_lock(&net->ipv4.ra_mutex); mutex_lock(&net->ipv4.ra_mutex);
for (rap = &net->ipv4.ra_chain; for (rap = &net->ipv4.ra_chain;
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册