提交 2db79a68 编写于 作者: X Xue 提交者: Xie XiuQi

net: hinic: fix bug in set vlan

driver inclusion
category:bugfix
bugzilla:4472
CVE:NA

-----------------------------------------------------------------------

When the ip link set is configured with the vlan vlan for the first time,
the default initial vlan id is 0. When the vlan is deleted, the new vlan id is 0.
The non-zero judgment is made when the interface is invoked, resulting in the
vlan id being 0. Returns an illegal value directly. This patch fix this bug.
Reviewed-by: NGuan Xiaodong <guanxiaodong@huawei.com>
Signed-off-by: NXue <xuechaojing@huawei.com>
Reviewed-by: NYang Yingliang <yangyingliang@huawei.com>
Signed-off-by: NYang Yingliang <yangyingliang@huawei.com>
上级 4b4ffac3
...@@ -460,8 +460,6 @@ int hinic_poll(struct napi_struct *napi, int budget) ...@@ -460,8 +460,6 @@ int hinic_poll(struct napi_struct *napi, int budget)
HINIC_MSIX_ENABLE); HINIC_MSIX_ENABLE);
else if (!nic_dev->in_vm) else if (!nic_dev->in_vm)
enable_irq(irq_cfg->irq_id); enable_irq(irq_cfg->irq_id);
} else {
hinic_rx_poll(irq_cfg->rxq, HINIC_RX_BUFFER_WRITE);
} }
return max(tx_pkts, rx_pkts); return max(tx_pkts, rx_pkts);
......
...@@ -346,7 +346,7 @@ int hinic_update_mac_vlan(void *hwdev, u16 old_vlan, u16 new_vlan, int vf_id) ...@@ -346,7 +346,7 @@ int hinic_update_mac_vlan(void *hwdev, u16 old_vlan, u16 new_vlan, int vf_id)
u16 func_id, vlan_id; u16 func_id, vlan_id;
int err; int err;
if (!hwdev || !old_vlan || !new_vlan) if (!hwdev || old_vlan >= VLAN_N_VID || new_vlan >= VLAN_N_VID)
return -EINVAL; return -EINVAL;
vf_info = dev->nic_io->vf_infos + HW_VF_ID_TO_OS(vf_id); vf_info = dev->nic_io->vf_infos + HW_VF_ID_TO_OS(vf_id);
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册