From 2d4de18dcadf29618f4d2ddd7a9a43f04c1e392c Mon Sep 17 00:00:00 2001 From: Luo Jiaxing Date: Thu, 20 Aug 2020 16:58:32 +0800 Subject: [PATCH] scsi: libsas: Remove postreset from sas_sata_ops mainline inclusion from mainline-v5.9-rc1 commit 3a243c2c35002f51ff1e62a4337cffe39b17f3d6 category: bugfix bugzilla: NA CVE: NA -------------------------------- sas_sata_ops uses ata_std_postreset as .postreset callback. However, ata_std_postreset() calls sata_scr_read()/sata_scr_write() which need to access the ATA SCR register. This register not available in the libsas case and the functions always return -EOPNOTSUPP. Drop the .postreset callback. Link: https://lore.kernel.org/r/1595408643-63011-2-git-send-email-luojiaxing@huawei.com Reviewed-by: John Garry Reviewed-by: Jason Yan Signed-off-by: Luo Jiaxing Signed-off-by: Martin K. Petersen Signed-off-by: Yang Yingliang --- drivers/scsi/libsas/sas_ata.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/scsi/libsas/sas_ata.c b/drivers/scsi/libsas/sas_ata.c index b627c9073585..1379db404665 100644 --- a/drivers/scsi/libsas/sas_ata.c +++ b/drivers/scsi/libsas/sas_ata.c @@ -648,7 +648,6 @@ void sas_ata_end_eh(struct ata_port *ap) static struct ata_port_operations sas_sata_ops = { .prereset = ata_std_prereset, .hardreset = sas_ata_hard_reset, - .postreset = ata_std_postreset, .error_handler = ata_std_error_handler, .post_internal_cmd = sas_ata_post_internal, .qc_defer = ata_std_qc_defer, -- GitLab