提交 20b78804 编写于 作者: J Julia Lawall 提交者: Karsten Keil

drivers/isdn/hardware/mISDN: move a dereference below a NULL test

In each case, if the NULL test is necessary, then the dereference should be
moved below the NULL test.

The semantic patch that makes this change is as follows:
(http://www.emn.fr/x-info/coccinelle/)

// <smpl>
@@
type T;
expression E;
identifier i,fld;
statement S;
@@

- T i = E->fld;
+ T i;
  ... when != E
      when != i
  if (E == NULL) S
+ i = E->fld;
// </smpl>
Signed-off-by: NJulia Lawall <julia@diku.dk>
Signed-off-by: NAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: NKarsten Keil <kkeil@suse.de>
上级 f27b8c35
...@@ -3615,7 +3615,7 @@ hfcm_bctrl(struct mISDNchannel *ch, u_int cmd, void *arg) ...@@ -3615,7 +3615,7 @@ hfcm_bctrl(struct mISDNchannel *ch, u_int cmd, void *arg)
static void static void
ph_state_change(struct dchannel *dch) ph_state_change(struct dchannel *dch)
{ {
struct hfc_multi *hc = dch->hw; struct hfc_multi *hc;
int ch, i; int ch, i;
if (!dch) { if (!dch) {
...@@ -3623,6 +3623,7 @@ ph_state_change(struct dchannel *dch) ...@@ -3623,6 +3623,7 @@ ph_state_change(struct dchannel *dch)
__func__); __func__);
return; return;
} }
hc = dch->hw;
ch = dch->slot; ch = dch->slot;
if (hc->type == 1) { if (hc->type == 1) {
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册