提交 11f0dd37 编写于 作者: D David Galiffi 提交者: Yang Yingliang

drm/amd/display: Fix dongle_caps containing stale information.

[ Upstream commit dd998291dbe92106d8c4a7581c409b356928d711 ]

[WHY]

During detection:
function: get_active_converter_info populates link->dpcd_caps.dongle_caps
only when dpcd_rev >= DPCD_REV_11 and DWN_STRM_PORTX_TYPE is
DOWN_STREAM_DETAILED_HDMI or DOWN_STREAM_DETAILED_DP_PLUS_PLUS.
Otherwise, it is not cleared, and stale information remains.

During mode validation:
function: dp_active_dongle_validate_timing reads
link->dpcd_caps.dongle_caps->dongle_type to determine the maximum
pixel clock to support. This information is now stale and no longer
valid.

[HOW]
dp_active_dongle_validate_timing should be using
link->dpcd_caps->dongle_type instead.
Signed-off-by: NDavid Galiffi <david.galiffi@amd.com>
Reviewed-by: NJun Lei <Jun.Lei@amd.com>
Acked-by: NBhawanpreet Lakha <Bhawanpreet.Lakha@amd.com>
Signed-off-by: NAlex Deucher <alexander.deucher@amd.com>
Signed-off-by: NSasha Levin <sashal@kernel.org>
Signed-off-by: NYang Yingliang <yangyingliang@huawei.com>
上级 782cd7fa
...@@ -1950,7 +1950,7 @@ static bool dp_active_dongle_validate_timing( ...@@ -1950,7 +1950,7 @@ static bool dp_active_dongle_validate_timing(
break; break;
} }
if (dongle_caps->dongle_type != DISPLAY_DONGLE_DP_HDMI_CONVERTER || if (dpcd_caps->dongle_type != DISPLAY_DONGLE_DP_HDMI_CONVERTER ||
dongle_caps->extendedCapValid == false) dongle_caps->extendedCapValid == false)
return true; return true;
......
...@@ -2172,6 +2172,7 @@ static void get_active_converter_info( ...@@ -2172,6 +2172,7 @@ static void get_active_converter_info(
uint8_t data, struct dc_link *link) uint8_t data, struct dc_link *link)
{ {
union dp_downstream_port_present ds_port = { .byte = data }; union dp_downstream_port_present ds_port = { .byte = data };
memset(&link->dpcd_caps.dongle_caps, 0, sizeof(link->dpcd_caps.dongle_caps));
/* decode converter info*/ /* decode converter info*/
if (!ds_port.fields.PORT_PRESENT) { if (!ds_port.fields.PORT_PRESENT) {
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册