From 1110f8e37d6601b19acdfa7fd0b0d63808156f6c Mon Sep 17 00:00:00 2001 From: Johannes Berg Date: Thu, 20 Oct 2016 09:44:05 +0200 Subject: [PATCH] iwlwifi: mvm: make iwl_dump_prph() void The return value is never used, so make the function void. Signed-off-by: Johannes Berg Signed-off-by: Luca Coelho --- drivers/net/wireless/intel/iwlwifi/mvm/fw-dbg.c | 16 ++++++---------- 1 file changed, 6 insertions(+), 10 deletions(-) diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/fw-dbg.c b/drivers/net/wireless/intel/iwlwifi/mvm/fw-dbg.c index 46ab6b9f680b..7df3c3f4749e 100644 --- a/drivers/net/wireless/intel/iwlwifi/mvm/fw-dbg.c +++ b/drivers/net/wireless/intel/iwlwifi/mvm/fw-dbg.c @@ -406,17 +406,17 @@ static const struct iwl_prph_range iwl_prph_dump_addr_9000[] = { { .start = 0x00a02400, .end = 0x00a02758 }, }; -static u32 iwl_dump_prph(struct iwl_trans *trans, - struct iwl_fw_error_dump_data **data, - const struct iwl_prph_range *iwl_prph_dump_addr, - u32 range_len) +static void iwl_dump_prph(struct iwl_trans *trans, + struct iwl_fw_error_dump_data **data, + const struct iwl_prph_range *iwl_prph_dump_addr, + u32 range_len) { struct iwl_fw_error_dump_prph *prph; unsigned long flags; - u32 prph_len = 0, i; + u32 i; if (!iwl_trans_grab_nic_access(trans, &flags)) - return 0; + return; for (i = 0; i < range_len; i++) { /* The range includes both boundaries */ @@ -425,8 +425,6 @@ static u32 iwl_dump_prph(struct iwl_trans *trans, int reg; __le32 *val; - prph_len += sizeof(**data) + sizeof(*prph) + num_bytes_in_chunk; - (*data)->type = cpu_to_le32(IWL_FW_ERROR_DUMP_PRPH); (*data)->len = cpu_to_le32(sizeof(*prph) + num_bytes_in_chunk); @@ -444,8 +442,6 @@ static u32 iwl_dump_prph(struct iwl_trans *trans, } iwl_trans_release_nic_access(trans, &flags); - - return prph_len; } /* -- GitLab