Skip to content

Q
qemu

openeuler / qemu

通知 10
Star 0
Fork 0
Q
qemu

体验新版 GitCode，发现更多精彩内容 >>

切换分支/标签
  1. 08 8月, 2016 1 次提交
  3. 02 8月, 2016 1 次提交
  5. 18 7月, 2016 1 次提交
  7. 17 7月, 2016 1 次提交
    • S
      checkpatch: consider git extended headers valid patches · d211bd60
      由 Stefan Hajnoczi 提交于 
      Renames look like this with git-diff(1) when diff.renames = true is set:

  diff --git a/a b/b
  similarity index 100%
  rename from a
  rename to b

This raises the "Does not appear to be a unified-diff format patch"
error because checkpatch.pl only considers a diff valid if it contains
at least one "@@" hunk.

This patch accepts renames and copies too so that checkpatch.pl exits
successfully when a diff only renames/copies files.  The git diff
extended header format is described on the git-diff(1) man page.
Reported-by: NColin Lord <clord@redhat.com>
Signed-off-by: NStefan Hajnoczi <stefanha@redhat.com>
Message-Id: <1468576014-28788-1-git-send-email-stefanha@redhat.com>
Signed-off-by: NPaolo Bonzini <pbonzini@redhat.com>
      d211bd60
  9. 30 6月, 2016 1 次提交
  11. 18 5月, 2016 1 次提交
  13. 05 4月, 2016 1 次提交
  15. 16 2月, 2016 2 次提交
  17. 13 1月, 2016 1 次提交
  19. 11 1月, 2016 1 次提交
  21. 13 10月, 2015 2 次提交
  23. 25 9月, 2015 1 次提交
  25. 16 9月, 2015 1 次提交
  27. 09 9月, 2015 2 次提交
  29. 28 4月, 2015 1 次提交
  31. 13 1月, 2015 1 次提交
    • M
      checkpatch: Brace handling on multi-line condition · a97ceca5
      由 Max Reitz 提交于 
      CODING_STYLE states the following about braces around blocks:

> The opening brace is on the line that contains the control flow
> statement that introduces the new block; [...]

This is obviously impossible with multi-line conditions. Therefore,
CODING_STYLE does not make any clear statement about where to put the
opening brace after a multi-line condition.

There is a reason to prefer to place the opening brace on an own line
after such a condition while still placing it on the same line as the
"control flow statement" if possible; that reason is that the last line
of a multi-line condition is indented, in the case of "if", it is often
indented by four spaces, just as much as the first statement in the
block will be indented. This is hard to read as there is no clearly
visible distinction between condition and block. Placing the opening
brace on a separate line solves this issue.

Also, there are cases where placing the opening brace on a separate line
is the only viable option; if the previous line had nearly 80 characters
and splitting it is not desirable, the opening brace is naturally placed
on an own line.

This patch fixes checkpatch.pl to not complain about braces on own lines
if the condition introducing the block spanned more than one line, or if
the previous line had 79 or 80 characters.

Furthermore, the warning about not having braces around a block is fixed
to mind braces not being on the last line of the condition.
Signed-off-by: NMax Reitz <mreitz@redhat.com>
Signed-off-by: NKevin Wolf <kwolf@redhat.com>
      a97ceca5
  33. 26 8月, 2014 1 次提交
  35. 10 9月, 2013 1 次提交
  37. 06 9月, 2012 4 次提交
  39. 22 6月, 2012 1 次提交
  41. 14 12月, 2011 1 次提交
  43. 02 12月, 2011 1 次提交
  45. 26 11月, 2011 1 次提交
  47. 02 11月, 2011 1 次提交
  49. 27 8月, 2011 1 次提交
  51. 21 7月, 2011 1 次提交
  53. 17 7月, 2011 1 次提交
    • A
      checkpatch: don't error out on },{ lines · 9fbe4784
      由 Alexander Graf 提交于 
      When having code like this:

    static PCIDeviceInfo piix_ide_info[] = {
        {
            .qdev.name    = "piix3-ide",
            .qdev.size    = sizeof(PCIIDEState),
            .qdev.no_user = 1,
            .no_hotplug   = 1,
            .init         = pci_piix_ide_initfn,
            .vendor_id    = PCI_VENDOR_ID_INTEL,
            .device_id    = PCI_DEVICE_ID_INTEL_82371SB_1,
            .class_id     = PCI_CLASS_STORAGE_IDE,
        },{
            .qdev.name    = "piix4-ide",
            .qdev.size    = sizeof(PCIIDEState),
            .qdev.no_user = 1,
            .no_hotplug   = 1,
            .init         = pci_piix_ide_initfn,
            .vendor_id    = PCI_VENDOR_ID_INTEL,
            .device_id    = PCI_DEVICE_ID_INTEL_82371AB,
            .class_id     = PCI_CLASS_STORAGE_IDE,
        },{
            /* end of list */
        }
    };

checkpatch currently errors out, claiming that spaces need to follow
commas. However, this particular style of defining structs is pretty
common in qemu code and very readable. So let's declare it as supported
for the above case.
Reported-by: NKevin Wolf <kwolf@redhat.com>
Signed-off-by: NAlexander Graf <agraf@suse.de>
      9fbe4784
  55. 05 2月, 2011 1 次提交
  57. 22 1月, 2011 1 次提交
  59. 21 1月, 2011 2 次提交