1. 17 12月, 2010 2 次提交
  2. 04 11月, 2010 1 次提交
  3. 22 10月, 2010 4 次提交
    • E
      Copy snapshots out of QCOW2 disk · 51ef6727
      edison 提交于
      In order to backup snapshots, created from QCOW2 iamge, we want to copy snapshots out of QCOW2 disk to a seperate storage.
      The following patch adds a new option in "qemu-img": qemu-img convert -f qcow2 -O qcow2 -s snapshot_name src_img bck_img.
      Right now, it only supports to copy the full snapshot, delta snapshot is on the way.
      
      Changes from V1: all the comments from Kevin are addressed:
      Add read-only checking
      Fix coding style
      Change the name from bdrv_snapshot_load to bdrv_snapshot_load_tmp
      Signed-off-by: NDisheng Su <edison@cloud.com>
      Signed-off-by: NKevin Wolf <kwolf@redhat.com>
      51ef6727
    • K
      qcow2: Remove old image creation function · 9b036055
      Kevin Wolf 提交于
      They have been #ifdef'd out by the previous patch.
      Signed-off-by: NKevin Wolf <kwolf@redhat.com>
      9b036055
    • K
      qcow2: Simplify image creation · a9420734
      Kevin Wolf 提交于
      Instead of doing lots of magic for setting up initial refcount blocks and stuff
      create a minimal (inconsistent) image, open it and initialize the rest with
      regular qcow2 functions.
      
      This is a complete rewrite of the image creation function. The old
      implementating is #ifdef'd out and will be removed by the next patch (removing
      it here would have made the diff unreadable because diff tries to find
      similarities when it's really a rewrite)
      Signed-off-by: NKevin Wolf <kwolf@redhat.com>
      a9420734
    • S
      qcow2: Support exact L1 table growth · 72893756
      Stefan Hajnoczi 提交于
      The L1 table grow operation includes a size calculation that bumps up
      the new L1 table size in order to anticipate the size needs of vmstate
      data.  This helps reduce the number of times that the L1 table has to be
      grown when vmstate data is appended.
      
      This size overhead is not necessary during image creation,
      bdrv_truncate(), or snapshot goto operations.  In fact, existing
      qemu-iotests that exercise table growth are no longer able to trigger it
      because image creation preallocates an L1 table that is too large after
      changes to qcow_create2().
      
      This patch keeps the size calculation but also adds exact growth for
      callers that do not want to inflate the L1 table size unnecessarily.
      Signed-off-by: NStefan Hajnoczi <stefanha@linux.vnet.ibm.com>
      Signed-off-by: NKevin Wolf <kwolf@redhat.com>
      72893756
  4. 21 9月, 2010 2 次提交
    • K
      qcow2: Avoid bounce buffers for AIO write requests · 6f5f060b
      Kevin Wolf 提交于
      qcow2 used to use bounce buffers for any AIO requests. This does not only imply
      unnecessary copying, but also unbounded allocations which should be avoided.
      
      This patch removes bounce buffers from the normal AIO write path. Encrypted
      images continue to use a bounce buffer, however with constant size.
      Signed-off-by: NKevin Wolf <kwolf@redhat.com>
      6f5f060b
    • K
      qcow2: Avoid bounce buffers for AIO read requests · bd28f835
      Kevin Wolf 提交于
      qcow2 used to use bounce buffers for any AIO requests. This does not only imply
      unnecessary copying, but also unbounded allocations which should be avoided.
      
      This patch removes bounce buffers from the normal AIO read path, and constrains
      them to a constant size for encrypted images.
      Signed-off-by: NKevin Wolf <kwolf@redhat.com>
      bd28f835
  5. 06 7月, 2010 1 次提交
  6. 02 7月, 2010 1 次提交
  7. 22 6月, 2010 1 次提交
  8. 28 5月, 2010 1 次提交
    • K
      qcow2: Allow qcow2_get_cluster_offset to return errors · 1c46efaa
      Kevin Wolf 提交于
      qcow2_get_cluster_offset() looks up a given virtual disk offset and returns the
      offset of the corresponding cluster in the image file. Errors (e.g. L2 table
      can't be read) are currenctly indicated by a return value of 0, which is
      unfortuately the same as for any unallocated cluster. So in effect we can't
      check for errors.
      
      This makes the old return value a by-reference parameter and returns the usual
      0/-errno error code.
      Signed-off-by: NKevin Wolf <kwolf@redhat.com>
      1c46efaa
  9. 22 5月, 2010 1 次提交
  10. 17 5月, 2010 1 次提交
  11. 08 5月, 2010 2 次提交
  12. 03 5月, 2010 2 次提交
    • S
      qcow2: Implement bdrv_truncate() for growing images · 419b19d9
      Stefan Hajnoczi 提交于
      This patch adds the ability to grow qcow2 images in-place using
      bdrv_truncate().  This enables qemu-img resize command support for
      qcow2.
      
      Snapshots are not supported and bdrv_truncate() will return -ENOTSUP.
      The notion of resizing an image with snapshots could lead to confusion:
      users may expect snapshots to remain unchanged, but this is not possible
      with the current qcow2 on-disk format where the header.size field is
      global instead of per-snapshot.  Others may expect snapshots to change
      size along with the current image data.  I think it is safest to not
      support snapshots and perhaps add behavior later if there is a
      consensus.
      
      Backing images continue to work.  If the image is now larger than its
      backing image, zeroes are read when accessing beyond the end of the
      backing image.
      Signed-off-by: NStefan Hajnoczi <stefanha@linux.vnet.ibm.com>
      Signed-off-by: NKevin Wolf <kwolf@redhat.com>
      419b19d9
    • K
      block: Open the underlying image file in generic code · 66f82cee
      Kevin Wolf 提交于
      Format drivers shouldn't need to bother with things like file names, but rather
      just get an open BlockDriverState for the underlying protocol. This patch
      introduces this behaviour for bdrv_open implementation. For protocols which
      need to access the filename to open their file/device/connection/... a new
      callback bdrv_file_open is introduced which doesn't get an underlying file
      opened.
      
      For now, also some of the more obscure formats use bdrv_file_open because they
      open() the file themselves instead of using the block.c functions. They need to
      be fixed in later patches.
      Signed-off-by: NKevin Wolf <kwolf@redhat.com>
      66f82cee
  13. 24 4月, 2010 1 次提交
  14. 23 4月, 2010 4 次提交
  15. 10 4月, 2010 2 次提交
  16. 10 3月, 2010 1 次提交
  17. 24 2月, 2010 1 次提交
  18. 27 1月, 2010 5 次提交
  19. 14 1月, 2010 2 次提交
  20. 04 12月, 2009 1 次提交
  21. 09 11月, 2009 1 次提交
  22. 28 10月, 2009 1 次提交
  23. 15 10月, 2009 1 次提交
    • K
      qcow2: Bring synchronous read/write back to life · ef845c3b
      Kevin Wolf 提交于
      When the synchronous read and write functions were dropped, they were replaced
      by generic emulation functions. Unfortunately, these emulation functions don't
      provide the same semantics as the original functions did.
      
      The original bdrv_read would mean that we read some data synchronously and that
      we won't be interrupted during this read. The latter assumption is no longer
      true with the emulation function which needs to use qemu_aio_poll and therefore
      allows the callback of any other concurrent AIO request to be run during the
      read. Which in turn means that (meta)data read earlier could have changed and
      be invalid now. qcow2 is not prepared to work in this way and it's just scary
      how many places there are where other requests could run.
      
      I'm not sure yet where exactly it breaks, but you'll see breakage with virtio
      on qcow2 with a backing file. Providing synchronous functions again fixes the
      problem for me.
      
      Patchworks-ID: 35437
      Signed-off-by: NKevin Wolf <kwolf@redhat.com>
      Signed-off-by: NAnthony Liguori <aliguori@us.ibm.com>
      ef845c3b
  24. 12 9月, 2009 1 次提交
    • B
      Fix sys-queue.h conflict for good · 72cf2d4f
      Blue Swirl 提交于
      Problem: Our file sys-queue.h is a copy of the BSD file, but there are
      some additions and it's not entirely compatible. Because of that, there have
      been conflicts with system headers on BSD systems. Some hacks have been
      introduced in the commits 15cc9235,
      f40d7537,
      96555a96 and
      3990d09a but the fixes were fragile.
      
      Solution: Avoid the conflict entirely by renaming the functions and the
      file. Revert the previous hacks.
      Signed-off-by: NBlue Swirl <blauwirbel@gmail.com>
      72cf2d4f