提交 ec10eada 编写于 作者: G Greg Kurz 提交者: Michael Roth

9pfs: local: truncate: don't follow symlinks

The local_truncate() callback is vulnerable to symlink attacks because
it calls truncate() which follows symbolic links in all path elements.

This patch converts local_truncate() to rely on open_nofollow() and
ftruncate() instead.

This partly fixes CVE-2016-9602.
Signed-off-by: NGreg Kurz <groug@kaod.org>
Reviewed-by: NStefan Hajnoczi <stefanha@redhat.com>
(cherry picked from commit ac125d99)
Signed-off-by: NGreg Kurz <gkurz@linux.vnet.ibm.com>
Signed-off-by: NMichael Roth <mdroth@linux.vnet.ibm.com>
上级 d3c54bf9
...@@ -895,13 +895,14 @@ err_out: ...@@ -895,13 +895,14 @@ err_out:
static int local_truncate(FsContext *ctx, V9fsPath *fs_path, off_t size) static int local_truncate(FsContext *ctx, V9fsPath *fs_path, off_t size)
{ {
char *buffer; int fd, ret;
int ret;
char *path = fs_path->data;
buffer = rpath(ctx, path); fd = local_open_nofollow(ctx, fs_path->data, O_WRONLY, 0);
ret = truncate(buffer, size); if (fd == -1) {
g_free(buffer); return -1;
}
ret = ftruncate(fd, size);
close_preserve_errno(fd);
return ret; return ret;
} }
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册