From e23a22e620e84f42bdbd473b82672654e7c8de73 Mon Sep 17 00:00:00 2001 From: Jens Osterkamp Date: Mon, 12 Apr 2010 10:51:01 +0200 Subject: [PATCH] qemu-sockets: avoid strlen of NULL pointer If the user wants to create a chardev of type socket but forgets to give a host= option, qemu_opt_get returns NULL. This NULL pointer is then fed into strlen a few lines below without a check which results in a segfault. This fixes it. Signed-off-by: Jens Osterkamp Signed-off-by: Aurelien Jarno --- qemu-sockets.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/qemu-sockets.c b/qemu-sockets.c index a7399aa945..c526324998 100644 --- a/qemu-sockets.c +++ b/qemu-sockets.c @@ -130,7 +130,8 @@ int inet_listen_opts(QemuOpts *opts, int port_offset) ai.ai_family = PF_UNSPEC; ai.ai_socktype = SOCK_STREAM; - if (qemu_opt_get(opts, "port") == NULL) { + if ((qemu_opt_get(opts, "host") == NULL) || + (qemu_opt_get(opts, "port") == NULL)) { fprintf(stderr, "%s: host and/or port not specified\n", __FUNCTION__); return -1; } -- GitLab