diff --git a/hw/arm/allwinner-a10.c b/hw/arm/allwinner-a10.c index 01206f243c68c6e61ed2e10cc4fc2273b71ce1bf..86965a72a52c4bf9a2f47b1302672b998c13cac2 100644 --- a/hw/arm/allwinner-a10.c +++ b/hw/arm/allwinner-a10.c @@ -92,6 +92,7 @@ static void aw_a10_realize(DeviceState *dev, Error **errp) sysbus_mmio_map(sysbusdev, 0, AW_A10_EMAC_BASE); sysbus_connect_irq(sysbusdev, 0, s->irq[55]); + /* FIXME use a qdev chardev prop instead of serial_hds[] */ serial_mm_init(get_system_memory(), AW_A10_UART0_REG_BASE, 2, s->irq[1], 115200, serial_hds[0], DEVICE_NATIVE_ENDIAN); } diff --git a/hw/char/cadence_uart.c b/hw/char/cadence_uart.c index a5dc2a43664c8a6dfdee6697327de42355e1b7d3..4f38f0c6a5eeb2f5e192de8ec8951ca0b829c9e6 100644 --- a/hw/char/cadence_uart.c +++ b/hw/char/cadence_uart.c @@ -483,6 +483,7 @@ static void cadence_uart_realize(DeviceState *dev, Error **errp) s->fifo_trigger_handle = timer_new_ns(QEMU_CLOCK_VIRTUAL, fifo_trigger_update, s); + /* FIXME use a qdev chardev prop instead of qemu_char_get_next_serial() */ s->chr = qemu_char_get_next_serial(); if (s->chr) { diff --git a/hw/char/digic-uart.c b/hw/char/digic-uart.c index 8abe944de6cb897231959fde7fced018d1559654..f272491ddbcf1223f140803bfad8d18f20e9c7c4 100644 --- a/hw/char/digic-uart.c +++ b/hw/char/digic-uart.c @@ -143,6 +143,7 @@ static void digic_uart_realize(DeviceState *dev, Error **errp) { DigicUartState *s = DIGIC_UART(dev); + /* FIXME use a qdev chardev prop instead of qemu_char_get_next_serial() */ s->chr = qemu_char_get_next_serial(); if (s->chr) { qemu_chr_add_handlers(s->chr, uart_can_rx, uart_rx, uart_event, s); diff --git a/hw/char/etraxfs_ser.c b/hw/char/etraxfs_ser.c index 460094e79e84f33ab1c81a15d7bdf2b0645fe184..3381b86bfe8dbd1355041d78d3a8d06113772500 100644 --- a/hw/char/etraxfs_ser.c +++ b/hw/char/etraxfs_ser.c @@ -219,6 +219,7 @@ static int etraxfs_ser_init(SysBusDevice *dev) "etraxfs-serial", R_MAX * 4); sysbus_init_mmio(dev, &s->mmio); + /* FIXME use a qdev chardev prop instead of qemu_char_get_next_serial() */ s->chr = qemu_char_get_next_serial(); if (s->chr) { qemu_chr_add_handlers(s->chr, diff --git a/hw/char/lm32_juart.c b/hw/char/lm32_juart.c index 628a86fc06dc73c1f618a085efa0fc989d8475a8..03285da00b8b8730004a3755e61cb3c6777e925e 100644 --- a/hw/char/lm32_juart.c +++ b/hw/char/lm32_juart.c @@ -117,6 +117,7 @@ static int lm32_juart_init(SysBusDevice *dev) { LM32JuartState *s = LM32_JUART(dev); + /* FIXME use a qdev chardev prop instead of qemu_char_get_next_serial() */ s->chr = qemu_char_get_next_serial(); if (s->chr) { qemu_chr_add_handlers(s->chr, juart_can_rx, juart_rx, juart_event, s); diff --git a/hw/char/lm32_uart.c b/hw/char/lm32_uart.c index 4f2096637d05b0dfb74ec41508b6402af56b027b..39cad494f81dd269975daf710693719929455283 100644 --- a/hw/char/lm32_uart.c +++ b/hw/char/lm32_uart.c @@ -258,6 +258,7 @@ static int lm32_uart_init(SysBusDevice *dev) "uart", R_MAX * 4); sysbus_init_mmio(dev, &s->iomem); + /* FIXME use a qdev chardev prop instead of qemu_char_get_next_serial() */ s->chr = qemu_char_get_next_serial(); if (s->chr) { qemu_chr_add_handlers(s->chr, uart_can_rx, uart_rx, uart_event, s); diff --git a/hw/char/milkymist-uart.c b/hw/char/milkymist-uart.c index d05b82534090e0fcd8449b140dc0f05cca6251f1..b79ea09874726d04dae02b3c9888c54002ea72a6 100644 --- a/hw/char/milkymist-uart.c +++ b/hw/char/milkymist-uart.c @@ -199,6 +199,7 @@ static void milkymist_uart_realize(DeviceState *dev, Error **errp) { MilkymistUartState *s = MILKYMIST_UART(dev); + /* FIXME use a qdev chardev prop instead of qemu_char_get_next_serial() */ s->chr = qemu_char_get_next_serial(); if (s->chr) { qemu_chr_add_handlers(s->chr, uart_can_rx, uart_rx, uart_event, s); diff --git a/hw/char/pl011.c b/hw/char/pl011.c index 0a451150e5a22cbed5486ddbf9bd82919de813e1..d1cf00f44944e2edcc34082cd2759f8dd729c6ac 100644 --- a/hw/char/pl011.c +++ b/hw/char/pl011.c @@ -293,6 +293,7 @@ static void pl011_realize(DeviceState *dev, Error **errp) { PL011State *s = PL011(dev); + /* FIXME use a qdev chardev prop instead of qemu_char_get_next_serial() */ s->chr = qemu_char_get_next_serial(); if (s->chr) { diff --git a/hw/char/stm32f2xx_usart.c b/hw/char/stm32f2xx_usart.c index 260b05304453aa795c2b458c55b64600ef855642..669c4e3b6f002a7330e61902bf51b22961e194d2 100644 --- a/hw/char/stm32f2xx_usart.c +++ b/hw/char/stm32f2xx_usart.c @@ -198,6 +198,7 @@ static void stm32f2xx_usart_init(Object *obj) TYPE_STM32F2XX_USART, 0x2000); sysbus_init_mmio(SYS_BUS_DEVICE(obj), &s->mmio); + /* FIXME use a qdev chardev prop instead of qemu_char_get_next_serial() */ s->chr = qemu_char_get_next_serial(); if (s->chr) { diff --git a/hw/char/xilinx_uartlite.c b/hw/char/xilinx_uartlite.c index f7c3cae2fac9558a5633cb1e9ac9f639dd45eba4..cb546848bbf7db532bcdbd86d0ea5b5f3f5dc5f0 100644 --- a/hw/char/xilinx_uartlite.c +++ b/hw/char/xilinx_uartlite.c @@ -205,6 +205,7 @@ static void xilinx_uartlite_realize(DeviceState *dev, Error **errp) { XilinxUARTLite *s = XILINX_UARTLITE(dev); + /* FIXME use a qdev chardev prop instead of qemu_char_get_next_serial() */ s->chr = qemu_char_get_next_serial(); if (s->chr) qemu_chr_add_handlers(s->chr, uart_can_rx, uart_rx, uart_event, s); diff --git a/hw/isa/pc87312.c b/hw/isa/pc87312.c index 2849e8d367bed51182554f735f2b40a76ed1f0fb..3b1fcec537bebec36f419d89cb785b588a5d48d0 100644 --- a/hw/isa/pc87312.c +++ b/hw/isa/pc87312.c @@ -278,6 +278,7 @@ static void pc87312_realize(DeviceState *dev, Error **errp) pc87312_hard_reset(s); if (is_parallel_enabled(s)) { + /* FIXME use a qdev chardev prop instead of parallel_hds[] */ chr = parallel_hds[0]; if (chr == NULL) { chr = qemu_chr_new("par0", "null", NULL); @@ -296,6 +297,7 @@ static void pc87312_realize(DeviceState *dev, Error **errp) for (i = 0; i < 2; i++) { if (is_uart_enabled(s, i)) { + /* FIXME use a qdev chardev prop instead of serial_hds[] */ chr = serial_hds[i]; if (chr == NULL) { snprintf(name, sizeof(name), "ser%d", i);