From d49bc1fb3e2ca981e1655b82cbd5ef6b301ce2ff Mon Sep 17 00:00:00 2001 From: Alexander Graf Date: Tue, 3 Jan 2012 19:15:16 +0100 Subject: [PATCH] PPC: 440: Ignore invalid PCI IRQs When running a 440 target, we currently get invalid irq_num values (-1) which completely confuse the IRQ setting code. This is most likely due to the missing qdev conversion. While this shouldn't happen in the first place and should really rather be fixed by converting the target, I dislike segfaults. So for now, let's just print a warning and ignore invalid irq_num values. Signed-off-by: Alexander Graf --- hw/ppc4xx_pci.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/hw/ppc4xx_pci.c b/hw/ppc4xx_pci.c index 2c69210225..1bf785b4b0 100644 --- a/hw/ppc4xx_pci.c +++ b/hw/ppc4xx_pci.c @@ -275,6 +275,10 @@ static void ppc4xx_pci_set_irq(void *opaque, int irq_num, int level) qemu_irq *pci_irqs = opaque; DPRINTF("%s: PCI irq %d\n", __func__, irq_num); + if (irq_num < 0) { + fprintf(stderr, "%s: PCI irq %d\n", __func__, irq_num); + return; + } qemu_set_irq(pci_irqs[irq_num], level); } -- GitLab