diff --git a/blockdev.c b/blockdev.c index e6c83494092856d2a2a499f256894dcbb66bb0da..a6f71f9d83ba99741c42bb31f010889edc16c6b3 100644 --- a/blockdev.c +++ b/blockdev.c @@ -992,9 +992,7 @@ DriveInfo *drive_new(QemuOpts *all_opts, BlockInterfaceType block_default_type, blk = blockdev_init(filename, bs_opts, &local_err); bs_opts = NULL; if (!blk) { - if (local_err) { - error_propagate(errp, local_err); - } + error_propagate(errp, local_err); goto fail; } else { assert(!local_err); diff --git a/docs/devel/build-system.txt b/docs/devel/build-system.txt index 52501f2ad99d59c98f9bb13cb263735a54a9cc84..f9fd27fab0c7293cf31d2eb0042ba9a2a7faad5d 100644 --- a/docs/devel/build-system.txt +++ b/docs/devel/build-system.txt @@ -393,7 +393,7 @@ all use $(obj) as a prefix to the target, e.g. This file provides the entry point used to build each individual system or userspace emulator target. Each enabled target has its own subdirectory. For example if configure is run with the argument -'--target-list=x86_64-softmmu', then a sub-directory 'x86_64-softmu' +'--target-list=x86_64-softmmu', then a sub-directory 'x86_64-softmmu' will be created, containing a 'Makefile' which symlinks back to Makefile.target diff --git a/hw/s390x/s390-pci-bus.c b/hw/s390x/s390-pci-bus.c index 99d0368868254f6be6ead752fa55b06e414e5260..f7458445c0f50a7ebf85944286433abd0c007170 100644 --- a/hw/s390x/s390-pci-bus.c +++ b/hw/s390x/s390-pci-bus.c @@ -731,9 +731,7 @@ static void s390_pcihost_realize(DeviceState *dev, Error **errp) css_register_io_adapters(CSS_IO_ADAPTER_PCI, true, false, S390_ADAPTER_SUPPRESSIBLE, &local_err); - if (local_err) { - error_propagate(errp, local_err); - } + error_propagate(errp, local_err); } static int s390_pci_msix_init(S390PCIBusDevice *pbdev) diff --git a/qga/commands-posix.c b/qga/commands-posix.c index 1877976522773231b040bdc311380b98ec472a06..2e719d9b6b9620499d7df2d19e2cf4c3a7f1034b 100644 --- a/qga/commands-posix.c +++ b/qga/commands-posix.c @@ -1573,10 +1573,7 @@ static bool systemd_supports_mode(SuspendMode mode, Error **errp) return true; } - if (local_err) { - error_propagate(errp, local_err); - } - + error_propagate(errp, local_err); return false; } @@ -1782,7 +1779,7 @@ static void guest_suspend(SuspendMode mode, Error **errp) if (!mode_supported) { error_setg(errp, "the requested suspend mode is not supported by the guest"); - } else if (local_err) { + } else { error_propagate(errp, local_err); } } diff --git a/target/i386/hvf/x86_decode.c b/target/i386/hvf/x86_decode.c index d125a6ef83254243915ca63973e057c2d26b9701..5f513c55635f2e4234eea20e525bf36514bbdd7c 100644 --- a/target/i386/hvf/x86_decode.c +++ b/target/i386/hvf/x86_decode.c @@ -525,8 +525,6 @@ static void decode_sldtgroup(CPUX86State *env, struct x86_decode *decode) X86_DECODE_CMD_INVL }; decode->cmd = group[decode->modrm.reg]; - printf("%llx: decode_sldtgroup: %d\n", env->hvf_emul->fetch_rip, - decode->modrm.reg); } static void decode_lidtgroup(CPUX86State *env, struct x86_decode *decode) diff --git a/vl.c b/vl.c index 9dbba36ad3ec2f95935bf4685320aa5b1551734c..f5c8ef973cdff4c2cff9606b2b8d5fc284466bcf 100644 --- a/vl.c +++ b/vl.c @@ -3154,11 +3154,8 @@ int main(int argc, char **argv, char **envp) Visitor *v; BlockdevOptions_queue *bdo; - v = qobject_input_visitor_new_str(optarg, "driver", &err); - if (!v) { - error_report_err(err); - exit(1); - } + v = qobject_input_visitor_new_str(optarg, "driver", + &error_fatal); bdo = g_new(BlockdevOptions_queue, 1); visit_type_BlockdevOptions(v, NULL, &bdo->bdo,