From a9a0d9b99a347b1413728992726f2bacf76d48ce Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= <marcandre.lureau@redhat.com>
Date: Thu, 6 Dec 2018 00:37:34 +0400
Subject: [PATCH] monitor: check if chardev can switch gcontext for OOB
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Not all backends are able to switch gcontext. Those backends cannot
drive a OOB monitor (the monitor would then be blocking on main
thread).
For example, ringbuf, spice, or more esoteric input chardevs like
braille or MUX.
We already forbid MUX because not all frontends are ready to run outside
main loop. Replace that by a context-switching feature check.
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Message-Id: <20181205203737.9011-5-marcandre.lureau@redhat.com>
[Error condition simplified, commit message adjusted accordingly]
Signed-off-by: Markus Armbruster <armbru@redhat.com>
---
monitor.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/monitor.c b/monitor.c
index 79afe99079..a1329d8a86 100644
--- a/monitor.c
+++ b/monitor.c
@@ -4562,9 +4562,10 @@ void monitor_init(Chardev *chr, int flags)
bool use_oob = flags & MONITOR_USE_OOB;
if (use_oob) {
- if (CHARDEV_IS_MUX(chr)) {
+ if (!qemu_chr_has_feature(chr, QEMU_CHAR_FEATURE_GCONTEXT)) {
error_report("Monitor out-of-band is not supported with "
- "MUX typed chardev backend");
+ "%s typed chardev backend",
+ object_get_typename(OBJECT(chr)));
exit(1);
}
if (use_readline) {
--
GitLab