From a39a24fbb05055d00026eb569ff3f7b868ca8785 Mon Sep 17 00:00:00 2001 From: Alberto Garcia Date: Mon, 26 Oct 2015 14:27:13 +0200 Subject: [PATCH] block: check for existing device IDs in external_snapshot_prepare() The 'snapshot-node-name' parameter of blockdev-snapshot-sync allows setting the node name of the image that is going to be created. Before creating the image, external_snapshot_prepare() checks that the name is not already being used. The check is however incomplete since it only considers existing node names, but node names must not clash with device IDs either because they share the same namespace. If the user attempts to create a snapshot using the name of an existing device for the 'snapshot-node-name' parameter the operation will eventually fail, but only after the new image has been created. This patch replaces bdrv_find_node() with bdrv_lookup_bs() to extend the check to existing device IDs, and thus detect possible name clashes before the new image is created. Signed-off-by: Alberto Garcia Reviewed-by: Max Reitz Reviewed-by: Jeff Cody Signed-off-by: Kevin Wolf --- blockdev.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/blockdev.c b/blockdev.c index 34f6e5bbb0..0c6c2a7845 100644 --- a/blockdev.c +++ b/blockdev.c @@ -1579,8 +1579,9 @@ static void external_snapshot_prepare(BlkTransactionState *common, return; } - if (has_snapshot_node_name && bdrv_find_node(snapshot_node_name)) { - error_setg(errp, "New snapshot node name already existing"); + if (has_snapshot_node_name && + bdrv_lookup_bs(snapshot_node_name, snapshot_node_name, NULL)) { + error_setg(errp, "New snapshot node name already in use"); return; } -- GitLab