From 8c6c919e281231dc3c77191b5a8c3c427ff17be8 Mon Sep 17 00:00:00 2001 From: aliguori Date: Mon, 26 Jan 2009 20:32:22 +0000 Subject: [PATCH] kvm-x86: Remove eflags conversion into emulator format (Jan Kiszka) It seems that the conversion of the kernel-delivered eflags state into qemu's internal split representation was once needed in an older kvm design (register read-back may have taken place from inside cpu_exec). Today it is plain wrong and causes incorrect cpu state reporting (gdb, monitor) and should also corrupt its saving (savevm, migration). Drop the related lines. Signed-off-by: Jan Kiszka Signed-off-by: Anthony Liguori git-svn-id: svn://svn.savannah.nongnu.org/qemu/trunk@6461 c046a42c-6fe2-441c-8c8c-71466251a162 --- target-i386/kvm.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/target-i386/kvm.c b/target-i386/kvm.c index 2412ae4340..49766e2579 100644 --- a/target-i386/kvm.c +++ b/target-i386/kvm.c @@ -445,10 +445,6 @@ static int kvm_get_sregs(CPUState *env) } } env->hflags = (env->hflags & HFLAG_COPY_MASK) | hflags; - env->cc_src = env->eflags & (CC_O | CC_S | CC_Z | CC_A | CC_P | CC_C); - env->df = 1 - (2 * ((env->eflags >> 10) & 1)); - env->cc_op = CC_OP_EFLAGS; - env->eflags &= ~(DF_MASK | CC_O | CC_S | CC_Z | CC_A | CC_P | CC_C); return 0; } -- GitLab