From 8c17d862b3cefed23a62c4e09d4b3f1f04a38631 Mon Sep 17 00:00:00 2001 From: Luke Shumaker Date: Thu, 28 Dec 2017 13:08:12 -0500 Subject: [PATCH] linux-user: init_guest_space: Add a comment about search strategy Signed-off-by: Luke Shumaker Message-Id: <20171228180814.9749-10-lukeshu@lukeshu.com> Reviewed-by: Peter Maydell Signed-off-by: Laurent Vivier --- linux-user/elfload.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/linux-user/elfload.c b/linux-user/elfload.c index 5c64299961..9d10a5f592 100644 --- a/linux-user/elfload.c +++ b/linux-user/elfload.c @@ -1910,6 +1910,10 @@ unsigned long init_guest_space(unsigned long host_start, * happen often. Probably means we got unlucky and host * address space randomization put a shared library somewhere * inconvenient. + * + * This is probably a good strategy if host_start, but is + * probably a bad strategy if not, which means we got here + * because of trouble with ARM commpage setup. */ munmap((void *)real_start, real_size); current_start += qemu_host_page_size; -- GitLab