From 7fd669a1c49743073e53166798244f15b1a8e0d2 Mon Sep 17 00:00:00 2001 From: Luiz Capitulino Date: Thu, 26 Nov 2009 22:58:54 -0200 Subject: [PATCH] monitor: Introduce monitor_find_command() This commit moves the loop which searches for the command entry corresponding to a command name to its own function. It will be used by QMP code as well. Signed-off-by: Luiz Capitulino Signed-off-by: Anthony Liguori --- monitor.c | 22 +++++++++++++++------- 1 file changed, 15 insertions(+), 7 deletions(-) diff --git a/monitor.c b/monitor.c index e202ba0024..fd0fa76f4a 100644 --- a/monitor.c +++ b/monitor.c @@ -2932,6 +2932,19 @@ static int is_valid_option(const char *c, const char *typestr) return (typestr != NULL); } +static const mon_cmd_t *monitor_find_command(const char *cmdname) +{ + const mon_cmd_t *cmd; + + for (cmd = mon_cmds; cmd->name != NULL; cmd++) { + if (compare_cmd(cmdname, cmd->name)) { + return cmd; + } + } + + return NULL; +} + static const mon_cmd_t *monitor_parse_command(Monitor *mon, const char *cmdline, QDict *qdict) @@ -2952,13 +2965,8 @@ static const mon_cmd_t *monitor_parse_command(Monitor *mon, if (!p) return NULL; - /* find the command */ - for(cmd = mon_cmds; cmd->name != NULL; cmd++) { - if (compare_cmd(cmdname, cmd->name)) - break; - } - - if (cmd->name == NULL) { + cmd = monitor_find_command(cmdname); + if (!cmd) { monitor_printf(mon, "unknown command: '%s'\n", cmdname); return NULL; } -- GitLab