From 6c615ec57e83bf8cc7b1721bcd58c7d1ed93ef65 Mon Sep 17 00:00:00 2001 From: Michael Roth Date: Mon, 14 May 2012 16:42:35 -0500 Subject: [PATCH] qemu-ga: fix segv after failure to open log file Currently, if we fail to open the specified log file (generally due to a permissions issue), we'll assign NULL to the logfile handle (stderr, initially) used by the logging routines, which can cause a segfault to occur when we attempt to report the error before exiting. Instead, only re-assign if the open() was successful. Reviewed-by: Michal Privoznik Signed-off-by: Michael Roth --- qemu-ga.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/qemu-ga.c b/qemu-ga.c index 3a88333a17..42e271f35f 100644 --- a/qemu-ga.c +++ b/qemu-ga.c @@ -836,12 +836,13 @@ int main(int argc, char **argv) become_daemon(pid_filepath); } if (log_filepath) { - s->log_file = fopen(log_filepath, "a"); - if (!s->log_file) { + FILE *log_file = fopen(log_filepath, "a"); + if (!log_file) { g_critical("unable to open specified log file: %s", strerror(errno)); goto out_bad; } + s->log_file = log_file; } } -- GitLab