From 18cb1d85578e03b16570d9380309cca673f9fff8 Mon Sep 17 00:00:00 2001 From: Anthony Liguori Date: Thu, 7 Jan 2010 07:55:34 -0600 Subject: [PATCH] vnc: Fix artifacts in hextile decoding 02c2b87 introduced a regression whereas the foreground color in a hextile update was not being properly invalidated leading to artifacts. It's still necessary to explicitly invalidate the foreground color with a SubrectColoured tile even though we no longer send a foreground color as part of the tile. Reported-by: Mark Cave-Ayland Signed-off-by: Anthony Liguori --- vnchextile.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/vnchextile.h b/vnchextile.h index 432ed89af4..78ed8c4e91 100644 --- a/vnchextile.h +++ b/vnchextile.h @@ -165,6 +165,8 @@ static void CONCAT(send_hextile_tile_, NAME)(VncState *vs, irow += ds_get_linesize(vs->ds) / sizeof(pixel_t); } + /* A SubrectsColoured subtile invalidates the foreground color */ + *has_fg = 0; if (n_data > (w * h * sizeof(pixel_t))) { n_colors = 4; flags = 0x01; -- GitLab