• N
    slirp: don't use "smb ports = 0" option · de305b13
    Nikolaus Rath 提交于
    The "smb ports = 0" option causes recent samba versions to crash. It was
    introduced in commit 157777ef with log message "Samba 3 support".
    However, a value of 0 has never been officially supported by smb and is
    also not necessary: if stdin is a socket, smb does not try to listen on
    any ports and uses just stdin. This is necessary to support inetd based
    operation (otherwise smbd would always fail when called from inetd,
    because inetd already listens on the SMB port). Since samba has
    supported inetd operation since pre-3.x, it should be safe to rely on
    this feature. I have tested it with Samba 3.6.4 -- communication works
    fine, and smbd is not listening on any ports.
    
    I suspect the "smb ports = 0" hack may have been introduced when someone
    tested the qemu generated samba config from the command line with "smbd
    -i" and found it to fail (because then stdin isn't a socket).
    Signed-off-by: NNikolaus Rath <Nikolaus@rath.org>
    Signed-off-by: NJan Kiszka <jan.kiszka@siemens.com>
    de305b13
slirp.c 21.5 KB