• P
    scsi-generic: Remove bogus double complete · 40f16dd1
    Paolo Bonzini 提交于
    scsi-generic scsi_read_complete() should not -both- call the client
    complete callback with SCSI_REASON_DATA -and- call
    scsi_command_complete().  The former will cause the client to queue a
    new read or write request, while the later will free the request data
    structure, thus causing the new read or write request to use a
    freed/stale structure when it completes.
    
    This patch fixes the bug, fixing a crash with scsi-generic & RHEL5.5
    installer.
    
    Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
    Cc: David Gibson <david@gibson.dropbear.id.au>
    Signed-off-by: NPaolo Bonzini <pbonzini@redhat.com>
    Reviewed-by: NChristoph Hellwig <hch@lst.de>
    40f16dd1
scsi-generic.c 15.6 KB