diff --git a/advisors/tc_review b/advisors/tc_review index fa051093f7687c6fb760cca57c8283922cd7510a..03eba151e881201aa1ad6d16c4e3da9049d0ccc4 100755 --- a/advisors/tc_review +++ b/advisors/tc_review @@ -49,31 +49,21 @@ def check_maintainer_changes(): def review(pr): review_body = "" - review_body += "[ ] Is the Title of this PR self-explain ?\n" - review_body += " PR的标题是否清晰易懂 ?\n" - review_body += "[ ] Is the description of this PR detailed ?\n" - review_body += " PR的内容描述是否详细具体 ?\n" - review_body += "[ ] Does the PR match the code changes ?\n" - review_body += " PR和实际代码修改是否一致 ?\n" + review_body += "[ ] PR的标题是否清晰易懂 ? / Is the Title of this PR self-explain ?\n" + review_body += "[ ] PR的内容描述是否详细具体 ? / Is the description of this PR detailed ?\n" + review_body += "[ ] PR和实际代码修改是否一致 ? / Does the PR match the code changes ?\n" sigs = check_maintainer_changes() if sigs: - review_body += "Changes in maintainship detected: \n" - review_body += "发现维护者变更: \n" - review_body += "[ ] If new maintainer added, are there any assertion on his/her capability on maintainship ?\n" - review_body += " 如果新增维护者,有没有对他/她能力的客观说明 ?\n" + review_body += "发现维护者变更 / Changes in maintainship detected: \n" + review_body += "[ ] 如果新增维护者,有没有对他/她能力的客观说明 ? / If new maintainer added, are there any assertion on his/her capability on maintainship ?\n" for sig in sigs: - review_body += "[ ] Do other maintainers of {sig} also agree to add/remove his/her as a maintainer ?\n".format(sig=sig) - review_body += " {sig} 中的其他维护者是否同意 增加/删除 维护者 ?\n".format(sig=sig) + review_body += "[ ] {sig} 中的其他维护者是否同意 增加/删除 维护者 ? / Do other maintainers of {sig} also agree to add/remove his/her as a maintainer ?\n".format(sig=sig) if check_repository_mgmt_changes(): - review_body += "Changes in sigs.yaml detected: \n" - review_body += "发现 sigs.yaml 变更: \n" - review_body += "[ ] Are all changed repositories managed by proper SIG ?\n" - review_body += " 是否所有变更的代码仓都被恰当的 SIG 管理 ?\n" - review_body += "[ ] Do all affected SIG maintainers agree the change ?\n" - review_body += " 是否所有受影响的 SIG 的维护者都同意这个变更 ?\n" + review_body += "发现 sigs.yaml 变更 / Changes in sigs.yaml detected: \n" + review_body += "[ ] 是否所有变更的代码仓都被恰当的 SIG 管理 ? / Are all changed repositories managed by proper SIG ?\n" + review_body += "[ ] 是否所有受影响的 SIG 的维护者都同意这个变更 ? / Do all affected SIG maintainers agree the change ?\n" if check_repository_changes(): - review_body += "[ ] Do newly introduced repository license compatible with openEuler ?\n" - review_body += " 新引入的代码仓的license授权是否都与 openEuler 兼容 ?\n" + review_body += "[ ] 新引入的代码仓的license授权是否都与 openEuler 兼容 ? / Do newly introduced repository license compatible with openEuler ?\n" return review_body def main():