- 26 4月, 2016 7 次提交
-
-
由 John Ferlan 提交于
Move the driver specific secretUsageIDForDef into secret_conf.c. It could be more of a general purpose API.
-
由 John Ferlan 提交于
New API's including unlocked and Locked versions in order to be able to use in either manner. Support for searching hash object lists instead of linked lists will replace existing secret_driver functions secretFindByUUID and secretFindByUsage
-
由 John Ferlan 提交于
Move virSecretObj from secret_driver.c to virsecretobj.h To support being able to create a hashed secrets list, move the virSecretObj to virsecretobj.h so that the code can at least find the definition. This should be a temporary situation while the virsecretobj.c code is patched in order to support a hashed secret object while still having the linked list support in secret_driver.c. Eventually, the goal is to move the virSecretObj into virsecretobj.c, although it is notable that the existing model from which virSecretObj was derived has virDomainObj in src/conf/domain_conf.h and virNetworkObj in src/conf/network_conf.h, so virSecretObj wouldn't be unique if it were to remain in virsecretobj.h Still adding accessors to fetch and store hashed object data will be the end goal. Add definitions and infrastucture in virsecretobj.c to create and handle a hashed virSecretObj and virSecretObjList including the class, object, lock setup, and disposal API's. Nothing will call these yet. This infrastructure will replace the forward linked list logic within the secret_driver, eventually.
-
由 Michal Privoznik 提交于
Our distcheck is broken. Well, it works but only by pure chance. When wireshark plugin is enabled, we try to query which path should the plugin be installed into. Firstly, we try to ask pkg-config as some releases of wireshark already sets corresponding variable in their pkg-config files. However, if we obtained no value from there we try to construct the path on our own. Based on our observations it usually is: $libdir/wireshark/plugins/$version/. Now, the problem is in the way we are deciding whether we have obtained the plugin directory from pkg-config or not. Simply said, we are checking wrong variable. The variable we are checking has never been set, thus in our test is empty and therefore we will always construct the plugin dir path on our own, regardless of its presence in the pkg-config file. To make things worse, after fixing this problem, VPATH build was broken as it now tried to install plugin into correct directory. Yes, this is problem, because --prefix was not honoured and everything but the plugin was installed into given prefix. I've managed to resolve this issue by replacing plugin dir prefix with our own. So when doing regular installation (our prefix == wireshark prefix), nothing changes. When doing VPATH build & installation plugin is installed into correctly prefixed dir. Signed-off-by: NMichal Privoznik <mprivozn@redhat.com>
-
由 Michal Privoznik 提交于
We do have something similar for installing init system files. Basically I'm trying to avoid the following warning produced by automake: tools/Makefile.am:429: warning: uninstall-local was already defined in condition TRUE, which includes condition WITH_BSD_NSS ... tools/Makefile.am:292: ... 'uninstall-local' previously defined here Signed-off-by: NMichal Privoznik <mprivozn@redhat.com>
-
由 Michal Privoznik 提交于
This target has been disabled historically for whatever reason. Now that we do uninstall properly enable the test again. Signed-off-by: NMichal Privoznik <mprivozn@redhat.com>
-
由 Michal Privoznik 提交于
This function - in contrast with qemuBuildCommandLine - merely constructs our internal command representation of a domain. This is then later compared against expected output. Or, this function is used also in virConnectDomainXMLToNative(). But due to a copy paste error this function, just like its image - has @forceFips argument that if enabled forces FIPS, otherwise mimics FIPS state in the host. If FIPS is enabled or forced the generated command line is different to state in which FIPS is disabled. Problem is, while this could be desired in the virConnectDomainXMLToNative() case, this is undesirable in the test suite as it will produce unpredicted results. Solution to this is to rename argument to @enableFips to specifically tell whether we expect command line to be build in either of fashions and make virConnectDomainXMLToNative() implementation fetch FIPS state and pass it to qemuProcessCreatePretendCmd(). Signed-off-by: NMichal Privoznik <mprivozn@redhat.com>
-
- 25 4月, 2016 19 次提交
-
-
由 Laine Stump 提交于
This error message was too specific, based on the incorrect assumption that any error was cause by auto-added bridges: failed to create PCI bridge on bus 2: too many devices with fixed addresses In practice you can't know if a bridge with an index <= the bus it's connecting to was added automatically, or if it was a mistake in explicit config, and the auto-add problem is going to be dealt with in a different way in an upcoming patch. The new message is this: PCI Controller at index 1 (0x01) has " bus='0x02', but bus must be <= index (note that index is given in both decimal and hex because it is formatted as decimal in the XML, but bus is formatted as hex, and displaying the hex value of index makes it easier to see the problem when index > 9 (which will often be the case with PCIe, since most controllers only have a single port, not 32 slots as with standard PCI)). Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1004593
-
由 Andrea Bolognani 提交于
Use L<> instead of C<> for URLs and man pages.
-
由 Andrea Bolognani 提交于
Format the text properly.
-
由 Andrea Bolognani 提交于
podchecker(1) complained about these, eg. *** WARNING: Verbatim paragraph in NAME section at line 3 in file tools/virt-host-validate.pod
-
由 Andrea Bolognani 提交于
No need to special-case this one: we can add it to EXTRA_DIST so that it will be shipped in any case, and if WITH_LOGIN_SHELL happens to be enabled we mark it for installation as well.
-
由 Andrea Bolognani 提交于
We can't use eg. @sysconfdir@ directly in the .pod file, because pod2man(1) will interpret that as a variable name and format it accordingly. Instead, we use eg. SYSCONFDIR and use a subsequent sed(1) call to turn it into the expected @sysconfdir@.
-
由 Andrea Bolognani 提交于
All $(MANINFILES) should be deleted on distclean.
-
由 Andrea Bolognani 提交于
Define $(PODFILES) and $(MANINFILES) so that adding a new man page only requires changes in a few, well defined spots.
-
由 Andrea Bolognani 提交于
The generated man pages may contain information that depend on the build configuration, so they should not be shipped but rather always built on the user's machine.
-
由 Andrea Bolognani 提交于
After this commit, all man pages are generated using the same two steps: 1. Process a source $command.pod file with pod2man(1) to obtain a valid man page in $command.$section.in 2. Process $command.$section.in with sed(1) to obtain the final man page in $command.$section
-
由 Andrea Bolognani 提交于
Man pages in daemon/ and src/ are being already subjected to this post-processing step: make it so those in tools/ are as well.
-
由 Andrea Bolognani 提交于
No file should be created inside $(srcdir) during build.
-
由 Andrea Bolognani 提交于
Instead of embedding the pod information inside the respective source files, store them in separate files. This allows us to reduce the number of custom build rules as most of the information can be inferred for the file name; moreover, text editors are more likely to use proper syntax highlighting for standalone pod files.
-
由 Andrea Bolognani 提交于
This is the source file for the virt-admin(1) manual page, so it should be shipped.
-
由 Peter Krempa 提交于
Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1329819
-
由 Martin Kletzander 提交于
QEMU_BLOCK_IOTUNE_MAX is the maximum inclusively, so let's modify the message so it makes sense. https://bugzilla.redhat.com/show_bug.cgi?id=1329041Signed-off-by: NMartin Kletzander <mkletzan@redhat.com>
-
由 Andrea Bolognani 提交于
When describing attributes and elements, we mostly stick to a certain pattern; however, there are a few cases when the information is not presented in the usual way. Since there doesn't seem to be any reason not to follow the tried and true formula, rework those bits to fit the rest of the documentation.
-
由 Andrea Bolognani 提交于
Commit 61b070cf cleaned up a number of cases where the <dt> element was used to document symbols, but the symbol itself was not inside a <code> element. To make sure we don't end up having to clean up again a few months from now, introduce a syntax-check rule that can spot such mistakes. All existing exceptions are marked as such, with either file or line granularity depending on the case.
-
由 Peter Krempa 提交于
libvirt-common.h is generated into builddir/include/libvirt. apibuild.py only operated on srcdir/inlcude/libvirt. With VPATH build srcdir/docs/libvirt-libvirt-common.html would not get generated and make RPM failed.
-
- 24 4月, 2016 3 次提交
-
-
由 Cole Robinson 提交于
This unifies the test scripts to all use the similar pattern added for schematests in ace4aecd. This gives the following - Enables running all tests from outside of tests/ dir - Drops redundant abs_* definitions, which are set by test-lib.sh - Drops unnecessary srcdir variable which was only used for sourcing test-lib.sh Behavior changes: - srcdir can no longer be overwritten, but I don't know why anyone would really need to... - Script VERBOSE setting no longer prints commands executed by test-lib.sh. if anyone cares I suggest handling this in test-lib.sh which already has other verbose style handling
-
由 Cole Robinson 提交于
We presently don't give any indication if the VirtualBox version isn't in our support whitelist.
-
由 Cole Robinson 提交于
These old tests expect to run against a real xen connection via xend running on the host. Our intentions for the test suite are that it doesn't require interacting with any specific host resources, so these don't really belong here.
-
- 23 4月, 2016 1 次提交
-
-
由 Laine Stump 提交于
This finishes the job started by commit 81f3839f - removing the erroneous reference to nonexistent "igmp-ipv6" protocol.
-
- 22 4月, 2016 10 次提交
-
-
由 John Ferlan 提交于
Add bolding for <dt><code> elements to make them "stick out" on the page rather that just a stream of text where the elements only differ by slightly different font style.
-
由 Andrea Bolognani 提交于
Most of the time, the <dt> tag is used when providing documentation for a symbol; enclose symbols in <code> tags to style them appropriately.
-
由 Peter Krempa 提交于
Ancient python didn't like the new list added in 99283874. Convert it to a dict.
-
由 Martin Kletzander 提交于
The values are currently limited to LLONG_MAX which causes some problems. QEMU conveniently changed their maximum to 1e15 (1 PB) which is enough for some time and we need to adapt to that so that we don't throw "Unknown error" messages. Strictly limiting these values actually fixes some corner case values (off-by-one checks in QEMU probably). Since values out of the new specified range do not overflow anything, change the type of error as well. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1317531Signed-off-by: NMartin Kletzander <mkletzan@redhat.com>
-
由 Cole Robinson 提交于
And confdata to virconfdata, since 'conf' can mean a few different things in libvirt
-
由 Cole Robinson 提交于
-
由 Cole Robinson 提交于
Store the test list in libvirtd_test_scripts, and use it where appropriate. This also fixes the fact that we didn't ship virsh-uriprecedence when libvirtd build is disabled.
-
由 Cole Robinson 提交于
$ echo -n 'log_level=1' > ~/.config/libvirt/libvirtd.conf $ libvirtd --timeout=10 2014-10-10 10:30:56.394+0000: 6626: info : libvirt version: 1.1.3.6, package: 1.fc20 (Fedora Project, 2014-09-08-17:50:42, buildvm-05.phx2.fedoraproject.org) 2014-10-10 10:30:56.394+0000: 6626: error : main:1261 : Can't load config file: configuration file syntax error: /home/rjones/.config/libvirt/libvirtd.conf:1: expecting a value: /home/rjones/.config/libvirt/libvirtd.conf Rather than try to fix this in the depths of the parser, just catch the case when a config file doesn't end in a newline, and manually append a newline to the content before parsing https://bugzilla.redhat.com/show_bug.cgi?id=1151409
-
由 Laine Stump 提交于
IGMP is used on IPv4 networks tp setup multicast group memberships. On IPv6, this job is done by Multicast Listener Discovery (MLD), which uses ICMPv6 packets rather than its own IP protocol number like IGMP. The nwfilter documentation lists "igmp-ipv6" as one of the possible protocols, but this is ignored (and stripped from the xml). This patch removes that erroneous reference. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1038888
-
由 Laine Stump 提交于
According to the dnsmasq manpage, the netmask for IPv4 address ranges will be auto-deteremined from the interface dnsmasq is listening on, but it can't do this for IPv6 for some reason - it instead assumes a network prefix of 64 for all IPv6 address ranges. If this is incorrect, dnsmasq will refuse to give out an address to clients, instead logging this message: dnsmasq-dhcp[2380]: no address range available for DHCPv6 request via virbr0 The solution is for libvirt to add ",$prefix" to all IPv6 dhcp-range arguments when building the dnsmasq.conf file. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1033739
-