From ffcd822578cfcb45789fbcf812df21dd32f15895 Mon Sep 17 00:00:00 2001 From: Peter Krempa Date: Mon, 4 May 2020 16:08:37 +0200 Subject: [PATCH] qemuBuildDiskDeviceStr: Use XML disk bus type names in error message There's no point using the qemu-specific disk bus names in the error message. Signed-off-by: Peter Krempa Reviewed-by: Michal Privoznik --- src/qemu/qemu_command.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index 9836972234..77f0d83054 100644 --- a/src/qemu/qemu_command.c +++ b/src/qemu/qemu_command.c @@ -1581,7 +1581,6 @@ qemuBuildDiskDeviceStr(const virDomainDef *def, virQEMUCapsPtr qemuCaps) { g_auto(virBuffer) opt = VIR_BUFFER_INITIALIZER; - const char *bus = virDomainDiskQEMUBusTypeToString(disk->bus); const char *contAlias; g_autofree char *backendAlias = NULL; g_autofree char *scsiVPDDeviceId = NULL; @@ -1838,7 +1837,8 @@ qemuBuildDiskDeviceStr(const virDomainDef *def, case VIR_DOMAIN_DISK_BUS_LAST: default: virReportError(VIR_ERR_INTERNAL_ERROR, - _("unsupported disk bus '%s' with device setup"), bus); + _("unsupported disk bus '%s' with device setup"), + NULLSTR(virDomainDiskBusTypeToString(disk->bus))); return NULL; } -- GitLab