From f7212f6bd3c06a9ca51039d16e7d0515ec56493d Mon Sep 17 00:00:00 2001
From: John Ferlan <jferlan@redhat.com>
Date: Tue, 30 Sep 2014 07:01:49 -0400
Subject: [PATCH] virhook: Resolve Coverity NULL_RETURNS

Coverity complains that many other callers to return err from
virGetLastError() will check if err is not NULL before dereferencing
it.  Just do the same here for safety.
---
 src/util/virhook.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/src/util/virhook.c b/src/util/virhook.c
index 25d0783bfb..ee19382c4a 100644
--- a/src/util/virhook.c
+++ b/src/util/virhook.c
@@ -300,7 +300,8 @@ virHookCall(int driver,
     if (ret < 0) {
         /* Convert INTERNAL_ERROR into known error.  */
         virErrorPtr err = virGetLastError();
-        virReportError(VIR_ERR_HOOK_SCRIPT_FAILED, "%s", err->message);
+        virReportError(VIR_ERR_HOOK_SCRIPT_FAILED, "%s",
+                       err ? err->message : _("unknown error"));
     }
 
     virCommandFree(cmd);
-- 
GitLab