From f3699636acd51956b0f68e0686ab779dec73af34 Mon Sep 17 00:00:00 2001 From: Andrea Bolognani Date: Tue, 6 Mar 2018 13:43:26 +0100 Subject: [PATCH] qemu: Ignore subsequent attempts to probe device properties In some cases, we are probing multiple devices for the same property and setting the corresponding capability if it's found on any of the devices: when that happens, we can quit early after finding the first property and avoiding a bunch of string comparisons. Signed-off-by: Andrea Bolognani --- src/qemu/qemu_capabilities.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c index 4dec0046df..853e8cefcf 100644 --- a/src/qemu/qemu_capabilities.c +++ b/src/qemu/qemu_capabilities.c @@ -1978,6 +1978,9 @@ virQEMUCapsProcessStringFlags(virQEMUCapsPtr qemuCaps, { size_t i, j; for (i = 0; i < nflags; i++) { + if (virQEMUCapsGet(qemuCaps, flags[i].flag)) + continue; + for (j = 0; j < nvalues; j++) { if (STREQ(values[j], flags[i].value)) { virQEMUCapsSet(qemuCaps, flags[i].flag); -- GitLab