From f2a76a263fad2c98bd4ab23950e08390bf9ebf66 Mon Sep 17 00:00:00 2001 From: John Ferlan Date: Tue, 21 Mar 2017 12:53:49 -0400 Subject: [PATCH] qemu: Always format formatStr for blockdev-snapshot-sync The qemuDomainSnapshotPrepare should always set a > 0 format value anyway, so remove the check. Found by Coverity. --- src/qemu/qemu_driver.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 0e065081db..6762952080 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -14072,8 +14072,7 @@ qemuDomainSnapshotCreateSingleDiskActive(virQEMUDriverPtr driver, dd->prepared = true; /* create the actual snapshot */ - if (dd->src->format) - formatStr = virStorageFileFormatTypeToString(dd->src->format); + formatStr = virStorageFileFormatTypeToString(dd->src->format); /* The monitor is only accessed if qemu doesn't support transactions. * Otherwise the following monitor command only constructs the command. -- GitLab