From ef6b3b625d4af52371542e3de203eaef4001522f Mon Sep 17 00:00:00 2001 From: Michal Privoznik Date: Wed, 12 Aug 2015 10:25:48 +0200 Subject: [PATCH] networkBandwidthUpdate: Don't blindly dereference pointers It may happen that an interface don't have any bandwidth set and a new one is to be set. In that case, @ifaceBand will be NULL. This will cause troubles later in the code when deciding what to do. Signed-off-by: Michal Privoznik --- src/network/bridge_driver.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/network/bridge_driver.c b/src/network/bridge_driver.c index 666078caa0..f57c4003d7 100644 --- a/src/network/bridge_driver.c +++ b/src/network/bridge_driver.c @@ -5048,8 +5048,8 @@ networkBandwidthUpdate(virDomainNetDefPtr iface, /* Okay, there are three possible scenarios: */ - if (ifaceBand->in && ifaceBand->in->floor && - newBandwidth->in && newBandwidth->in->floor) { + if (ifaceBand && ifaceBand->in && ifaceBand->in->floor && + newBandwidth && newBandwidth->in && newBandwidth->in->floor) { /* Either we just need to update @floor .. */ if (virNetDevBandwidthUpdateRate(network->def->bridge, -- GitLab