From e6367dd408659e7118f4a46c27daee5b749a9b74 Mon Sep 17 00:00:00 2001 From: Erik Skultety Date: Wed, 16 Mar 2016 16:22:30 +0100 Subject: [PATCH] virlog: Fix build breaker with "comparison between signed and unsigned" Refactor series 0b231195 worked with virLogDestination type which, depending on the compiler, might be (and probably will be) an unsigned data type. However, virEnumFromString may return -1 in case of an error. So, when enum happens to be unsigned, some compilers will naturally complain about foo: 'if (foo < 0)' --- src/util/virlog.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/util/virlog.c b/src/util/virlog.c index 591d38e413..007fc65ebf 100644 --- a/src/util/virlog.c +++ b/src/util/virlog.c @@ -1088,7 +1088,7 @@ virLogParseOutput(const char *src) char *abspath = NULL; size_t count = 0; virLogPriority prio; - virLogDestination dest; + int dest; bool isSUID = virIsSUID(); if (!src) -- GitLab