From e4943fce3be4dbb293f17c0c75f283461869ea5a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?J=C3=A1n=20Tomko?= Date: Wed, 16 Oct 2019 15:58:28 +0200 Subject: [PATCH] docs: hacking: separate section about already deleted macros MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Move the recently deleted libvirt macros into a separate section. Signed-off-by: Ján Tomko Reviewed-by: Michal Privoznik --- docs/hacking.html.in | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/docs/hacking.html.in b/docs/hacking.html.in index de450b7cde..92826c5d44 100644 --- a/docs/hacking.html.in +++ b/docs/hacking.html.in @@ -1029,6 +1029,15 @@ BAD: instead. Don't use g_vasprintf unless having the string length returned is unavoidable. +
virStrerror
+
The GLib g_strerror() function should be used instead, + which has a simpler calling convention as an added benefit.
+ + +

+ The following libvirt APIs have been deleted already: +

+
VIR_AUTOPTR, VIR_AUTOCLEAN, VIR_AUTOFREE
The GLib macros g_autoptr, g_auto and g_autofree must be used instead in all new code. In existing code, the GLib macros must @@ -1051,10 +1060,6 @@ BAD:
The GLib macros g_autoptr and G_DEFINE_AUTOPTR_CLEANUP_FUNC should be used to manage autoclean of virObject classes. This matches usage with GObject classes.
- -
virStrerror
-
The GLib g_strerror() function should be used instead, - which has a simpler calling convention as an added benefit.

File handling

-- GitLab