From dc40dd605800c560dec6ec73b7bbd922666e5d73 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?S=C5=82awek=20Kap=C5=82o=C5=84ski?= Date: Wed, 19 Oct 2016 22:57:48 +0200 Subject: [PATCH] networkValidate: Forbid new-line char in network name New line character in name of network is now forbidden because it mess virsh output and can be confusing for users. Validation of name is done in network driver, after parsing XML to avoid problems with disappeared network which was already created with new-line char in name. Closes-Bug: https://bugzilla.redhat.com/show_bug.cgi?id=818064 Signed-off-by: Michal Privoznik --- src/network/bridge_driver.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/network/bridge_driver.c b/src/network/bridge_driver.c index b2af482725..9d7fc31f8f 100644 --- a/src/network/bridge_driver.c +++ b/src/network/bridge_driver.c @@ -2973,6 +2973,9 @@ networkValidate(virNetworkDriverStatePtr driver, bool bandwidthAllowed = true; bool usesInterface = false, usesAddress = false; + if (virXMLCheckIllegalChars("name", def->name, "\n") < 0) + return -1; + /* Only the three L3 network types that are configured by libvirt * need to have a bridge device name / mac address provided */ -- GitLab