From d91f7dec466bb086900165b86b2e2ac5bcef67f5 Mon Sep 17 00:00:00 2001 From: Osier Yang Date: Tue, 8 Jan 2013 01:05:30 +0800 Subject: [PATCH] nodedev: Use access instead of stat The use of 'stat' in nodeDeviceVportCreateDelete is only to check if the file exists or not, it's a bit overkill, and safe to replace with the wrapper of access(2) (virFileExists). --- src/node_device/node_device_driver.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/src/node_device/node_device_driver.c b/src/node_device/node_device_driver.c index 64fd8316e3..87e7e3ea3a 100644 --- a/src/node_device/node_device_driver.c +++ b/src/node_device/node_device_driver.c @@ -28,7 +28,6 @@ #include #include #include -#include #include "virerror.h" #include "datatypes.h" @@ -422,7 +421,6 @@ nodeDeviceVportCreateDelete(const int parent_host, int retval = 0; char *operation_path = NULL, *vport_name = NULL; const char *operation_file = NULL; - struct stat st; switch (operation) { case VPORT_CREATE: @@ -450,7 +448,7 @@ nodeDeviceVportCreateDelete(const int parent_host, goto cleanup; } - if (stat(operation_path, &st) != 0) { + if (!virFileExists(operation_path)) { VIR_FREE(operation_path); if (virAsprintf(&operation_path, "%shost%d%s", @@ -462,7 +460,7 @@ nodeDeviceVportCreateDelete(const int parent_host, goto cleanup; } - if (stat(operation_path, &st) != 0) { + if (!virFileExists(operation_path)) { VIR_ERROR(_("No vport operation path found for host%d"), parent_host); retval = -1; -- GitLab