From d41e1aa16985661d4046331feff193dc6e2a275a Mon Sep 17 00:00:00 2001 From: Peter Krempa Date: Wed, 15 May 2019 11:10:16 +0200 Subject: [PATCH] qemu: driver: Don't try to update blockjob status in qemuDomainGetBlockJobInfo MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit All blockjobs get their status updated by events from qemu, so this code no longer makes sense. Signed-off-by: Peter Krempa Reviewed-by: Ján Tomko --- src/qemu/qemu_driver.c | 14 -------------- 1 file changed, 14 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 9c0796b0a4..4766bc1299 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -17442,20 +17442,6 @@ qemuDomainGetBlockJobInfo(virDomainPtr dom, goto endjob; } - /* Snoop block copy operations, so future cancel operations can - * avoid checking if pivot is safe. Save the change to XML, but - * we can ignore failure because it is only an optimization. We - * hold the vm lock, so modifying the in-memory representation is - * safe, even if we are a query rather than a modify job. */ - if (disk->mirror && - rawInfo.ready != 0 && - info->cur == info->end && !disk->mirrorState) { - virQEMUDriverConfigPtr cfg = virQEMUDriverGetConfig(driver); - - disk->mirrorState = VIR_DOMAIN_DISK_MIRROR_STATE_READY; - ignore_value(virDomainSaveStatus(driver->xmlopt, cfg->stateDir, vm, driver->caps)); - virObjectUnref(cfg); - } endjob: qemuDomainObjEndJob(driver, vm); -- GitLab