From d070e1d1bce4ff9272bce8575f39070f7c330895 Mon Sep 17 00:00:00 2001
From: Osier Yang <jyang@redhat.com>
Date: Sat, 28 Apr 2012 16:18:44 +0800
Subject: [PATCH] storage: Break out the loop if duplicate pool is found

It doesn't break out the "for" loop even if duplicate pool is
found, and thus the "matchpool" could be overriden as NULL again
if there is different pool afterwards.

To address the problem in libvirt-user list:

https://www.redhat.com/archives/libvirt-users/2012-April/msg00150.html
(cherry picked from commit 980f12be7221b07e569fed24b372ea00c52d9511)
---
 src/conf/storage_conf.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/src/conf/storage_conf.c b/src/conf/storage_conf.c
index 75793277da..9a42e3496f 100644
--- a/src/conf/storage_conf.c
+++ b/src/conf/storage_conf.c
@@ -1710,6 +1710,9 @@ int virStoragePoolSourceFindDuplicate(virStoragePoolObjListPtr pools,
             break;
         }
         virStoragePoolObjUnlock(pool);
+
+        if (matchpool)
+            break;
     }
 
     if (matchpool) {
-- 
GitLab