From d042d339d1f020e449c0e0d4e7e601ed7a03ea9e Mon Sep 17 00:00:00 2001 From: "Daniel P. Berrange" Date: Mon, 22 Jan 2007 20:43:02 +0000 Subject: [PATCH] Fix crash in virsh connect command --- ChangeLog | 7 ++++++- src/virsh.c | 2 +- 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/ChangeLog b/ChangeLog index 62f6a72799..6b690de7db 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,9 +1,14 @@ +Mon Jan 22 15:41:52 EST 2007 Daniel Berrange + + * src/virsh.c: Fix crash in 'connect' command by ensuring + we always strdup the connection URI string. + Mon Jan 22 16:23:52 IST 2007 Mark McLoughlin * src/internal.h: virDomain.handle refers to the "id" in the API, so re-name to virDomain.id to avoid confusion. - + * src/hash.c, src/libvirt.c, src/proxy_internal.c, src/test.c, src/xen_internal.c, src/xend_internal.c, src/xm_internal.c, src/xml.c, src/xs_internal.c: update for rename. diff --git a/src/virsh.c b/src/virsh.c index 30b5c6b1de..b04f88e137 100644 --- a/src/virsh.c +++ b/src/virsh.c @@ -292,7 +292,7 @@ cmdConnect(vshControl * ctl, vshCmd * cmd) if (ctl->name) free(ctl->name); - ctl->name = vshCommandOptString(cmd, "name", NULL); + ctl->name = vshStrdup(ctl, vshCommandOptString(cmd, "name", NULL)); if (!ro) ctl->conn = virConnectOpen(ctl->name); -- GitLab